Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4490-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/4] shared/bap: Fix uninitialized field at BASE generation
Date: Fri, 10 May 2024 17:27:51 +0300
Message-Id: <20240510142754.3901-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20240510142754.3901-1-iulia.tanasescu@nxp.com>
References: <20240510142754.3901-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MMWAwzLNXqe0lNW0A8G4G1krAlzTnZc0NfzE7Ne0uXOeeNjLRKR+eV0OivcU?=
 =?us-ascii?Q?7XBC4zhYsmRa+57EJY/GEIPt5otguF9Cr6I/4FXeqW+0hL4bjjFHUj+RTCRK?=
 =?us-ascii?Q?oQH3Qc4W9SKPWCI7ouMSNHTfqGpoDtWBsEnt6Lqsp/RrTQp7v4S0b3Pchva3?=
 =?us-ascii?Q?GeQTPTnUTgc6n2oVLMBOiV36NxnXTZmC9TZ6vCbAu9cuvnyBw7/H6LGA8MqK?=
 =?us-ascii?Q?GJhmCJXMo5QB+8bsEwoAvA8SVy6teybG808ucMai9jgP14Qv/xO6YfhmB1jg?=
 =?us-ascii?Q?P2BcY/NckmSDRrcMGyhc2q23arz04PrRuhCBUnC5fFXRSBCMjou/4rm17dYB?=
 =?us-ascii?Q?nAdng19EChz/LaB2/oN/hlwyIiYXQUWV+bCC3UWyrsxE/FidVjCRVYyK9xmM?=
 =?us-ascii?Q?DZ8ks3YvHlAs5M6atn6mPgBPzShY/H8uWB7K9fht6jURcyleJwgwTRI63jnN?=
 =?us-ascii?Q?RH8m7cbIHO3xqx4cehiUleuGaWzSjBUPLXFO4wjeQy5w+sS4qveZ1Te3RvHk?=
 =?us-ascii?Q?RmVPCPmx8kncvlokCooSTStVBXzTyzij714JbONZWmxshig6Pm4PtRYulT58?=
 =?us-ascii?Q?of8OJnm46Ek5IuvjyZVdPJltaufJfV2kbUKGmyLBFkEW5wsuTrhVbNKMONKK?=
 =?us-ascii?Q?rT6XndaYmD8yOSo5HMHbGgU5ZQ59XsD7pFv6hV1R33rcxQVAoczb1lJNO5+7?=
 =?us-ascii?Q?LezGQbGJkUlAexjUlkbP1W24TAFgruuP2/yROjQx222CHtySkxwUSqWWPrUJ?=
 =?us-ascii?Q?8iL9EqOLMqEZHJVi/5bjFucw8Wd8tD2zOTk8vxtithcZJMU0tAZwjdv/5VJX?=
 =?us-ascii?Q?XkSRrP1BwIvJb/pz96BVGUO0dfHTa8IBfPUwgi9vh+R9CLaRHJb8ihHUnlSe?=
 =?us-ascii?Q?gDANuSAswMjeG5kyagCvbpFNicpKxkxShmNJhBmyQzHDWLK/pZ3d7bTZRP45?=
 =?us-ascii?Q?A7Klvq+IP1BG6y72Sp1Be99IgdxJQ1kBKOP0aDoWRwX2SBleSz+IgUxRmxq7?=
 =?us-ascii?Q?JTQsuhlk8Ai0keEb77nslb9NuZNXCvZI+teWB+qCCdbEg3UuDdeksmg0rH79?=
 =?us-ascii?Q?fuHDjfIKc+SLSljMENbxA+kV/i+pWjFRX3L4UHQIj3Fs5FgakwyePVSgffei?=
 =?us-ascii?Q?xR007uYJL/ijq0LsA22emfuUVRtYfCR0gn0rZ6UiN7sg8akSPQSxsHxR3+0s?=
 =?us-ascii?Q?IW3rKl2uqEkPOs3jGGUoMx272DqRl+4g+VYFvmONZx/h8EQUd6ZcIzltUriB?=
 =?us-ascii?Q?k0OAJ+5COkrqqh7dMso6r+OhB1DPl7mgsF1NInJPtmXt5WrEIUfwZf7QqxGh?=
 =?us-ascii?Q?+q1k5lB81r1nZ/Ijjjmav08dJWQtMC8+VkbKwd95D1q6nA5Y8n+lQdpzCh+K?=
 =?us-ascii?Q?Os7MVKgUK0SM/W9BSUckCd+6NXvu9Wxw2yRulUqcsvoEmceWL6n7o/iTsuHc?=
 =?us-ascii?Q?TFB7//2oSJnbFtLjExlGReKRjel8ABe+MeEdiSGMmrXU+RllBsVEcsDsent0?=
 =?us-ascii?Q?he3LWBBd7mIp2gLYj6O6kez7O+FaH9iw3hxA8w5LsmKWMjeLxAc0Kyo3DlvD?=
 =?us-ascii?Q?kVqWeH3AUvC36pWJpyYhXxJvcLiJrNrnGghK4iug+o2JAflzlOUll2NcUFJG?=
 =?us-ascii?Q?Cw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec997fd7-8841-4f13-096f-08dc70fd66d6
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 14:28:03.5275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZDszlhGnfq6WQpL1UkwkXqideb3VbFsM47CdjcF0V/dbAEYLynmXpZJBgn3mDDwQri8gN10Vnbr+dZr6Jt2W7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9592

Currently in bt_bap_stream_get_base, the pres_delay inside the base
variable is left uninitialized and it is later accessed in
set_base_subgroup, to be compared to each stream presentation delay.

This commit adds a fix by initializing the pres_delay field to the
current stream presentation delay, before later updating it based on
comparison.
---
 src/shared/bap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 818326f45..1316d7c73 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -6321,6 +6321,7 @@ struct iovec *bt_bap_stream_get_base(struct bt_bap_stream *stream)
 	base.subgroups = queue_new();
 	base.next_bis_index = 1;
 	base.big_id = stream->qos.bcast.big;
+	base.pres_delay = stream->qos.bcast.delay;
 
 	/* If the BIG ID was explicitly set, create a BASE with information
 	 * from all streams belonging to this BIG. Otherwise, create a BASE
-- 
2.39.2