Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3ddebd00-4c3e-4b80-88a8-50906e86b6fa@gmx.net>
Date: Sun, 12 May 2024 14:54:42 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] Bluetooth: hci_bcm4377: Increase boot timeout
To: sven@svenpeter.dev, Hector Martin <marcan@marcan.st>,
 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
 Marcel Holtmann <marcel@holtmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
 linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240512-btfix-msgid-v1-0-ab1bd938a7f4@svenpeter.dev>
 <20240512-btfix-msgid-v1-1-ab1bd938a7f4@svenpeter.dev>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20240512-btfix-msgid-v1-1-ab1bd938a7f4@svenpeter.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:L5PpRHjVWwU=;MmaKHzK0c2w6z2F2Xbl+MQcS+I+
 t8a6zhJ1uNNpmLKnQysMceeuJvuFZj1dHMMTGCkkD9Js7mqW8uJPTQZN4gGYQTVr3FCi30j3I
 b64NBN8LN4MWqMIwwCilGswYq8AAaEz7Ofaa/Nxq0ZO44pvEafATCHJZOLhwaRhAakDWgskPe
 fRv62VHsVJi+PMLl/2fkXLY3UJvxuHzojmHNOfzWQPyB91o5oL2Nq79896/XWlvHjrhVfBWCn
 b/ATnSBhZ7rk5UQUiI0fRS2NpOb39XvdmzWtW78GKbUaM7Fgt29akObIlNRx1vWrnaF0Jzk58
 R7rZkym18p1AkFXkn1nua3lj5cpFF882dWksMNvnDvU1bwqMwqLbchvp78RDmO8gs4V48ZOTC
 IdokiThSNZ/crKfogDl/AhoEHD3afBYJhkDZtvwtxZ0TlaOA+FcbWWwMqEshUYgpbpHUlcmrE
 tsxxlHBUftwj6ITx+HXvL8TALHAGDPZyJhBozN0mm63K/HCzsEGmI4xQFP6otx6SxveRcv711
 hmC7L0z89gmQ7SCFzVWVCfrswFjnrBlr/5wVdO6GhHrpNghU5SS5lVtwp6oxwnVIpvkTuj43u
 fTyn1+35IvHnOBkf81m1aBUR8rt3nSRBzpWjmQIHc4yoW0EPrir4Eb+mznq9H8CvBcQ4nWwip
 1BUQAPE23BVavG4a/YciN9onBDI+5zO6FKFaW7YRFoVgPbxg5dJnuzCk4hCwSPIYY3M67ClLb
 FgrEXcej523oXrODx6QNAK9uTb1zja/oiAt5P0z2EUxhYKLIGzzFxr1RHFY+jQiMlHqPsL8eV
 hrE5bt/8Ju2SfbgE58zDvVTPBW3sFNNF3e2GKX+lPgWtQ=

Hi Sven,

Am 12.05.24 um 14:12 schrieb Sven Peter via B4 Relay:
> From: Hector Martin <marcan@marcan.st>
>
> BCM4388 takes over 2 seconds to boot, so increase the timeout (and also
> fix the units while we're here).
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
>   drivers/bluetooth/hci_bcm4377.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm=
4377.c
> index 9a7243d5db71..5b818a0e33d6 100644
> --- a/drivers/bluetooth/hci_bcm4377.c
> +++ b/drivers/bluetooth/hci_bcm4377.c
> @@ -32,7 +32,8 @@ enum bcm4377_chip {
>   #define BCM4378_DEVICE_ID 0x5f69
>   #define BCM4387_DEVICE_ID 0x5f71
>
> -#define BCM4377_TIMEOUT 1000
> +#define BCM4377_TIMEOUT msecs_to_jiffies(1000)
this change affect all timeouts not just the boot timeout, so i would
prefer to split this.
> +#define BCM4377_BOOT_TIMEOUT msecs_to_jiffies(5000)
>
>   /*
>    * These devices only support DMA transactions inside a 32bit window
> @@ -1857,7 +1858,7 @@ static int bcm4377_boot(struct bcm4377_data *bcm43=
77)
>   	dev_dbg(&bcm4377->pdev->dev, "waiting for firmware to boot\n");
>
>   	ret =3D wait_for_completion_interruptible_timeout(&bcm4377->event,
> -							BCM4377_TIMEOUT);
> +							BCM4377_BOOT_TIMEOUT);
>   	if (ret =3D=3D 0) {
>   		ret =3D -ETIMEDOUT;
>   		goto out_dma_free;
>