Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <AS8PR02MB7237262C62B054FABD7229168BE12@AS8PR02MB7237.eurprd02.prod.outlook.com>
 <d11dacfa-5925-4040-b60b-02ab731d5f1a@kernel.org>
In-Reply-To: <d11dacfa-5925-4040-b60b-02ab731d5f1a@kernel.org>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 13 May 2024 12:29:04 -0400
Message-ID: <CABBYNZ+4CcoBvkj8ze7mZ4vVfWfm_tyBxdFspvreVASi0VR=6A@mail.gmail.com>
Subject: Re: [PATCH v2] tty: rfcomm: prefer struct_size over open coded arithmetic
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Erick Archer <erick.archer@outlook.com>, Marcel Holtmann <marcel@holtmann.org>, 
	Johan Hedberg <johan.hedberg@gmail.com>, "David S. Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Kees Cook <keescook@chromium.org>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, 
	Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, 
	Bill Wendling <morbo@google.com>, Justin Stitt <justinstitt@google.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Geert Uytterhoeven <geert@linux-m68k.org>, 
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, 
	llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jiri, Eric,

On Mon, May 13, 2024 at 1:07=E2=80=AFAM Jiri Slaby <jirislaby@kernel.org> w=
rote:
>
> On 12. 05. 24, 13:17, Erick Archer wrote:
> > This is an effort to get rid of all multiplications from allocation
> > functions in order to prevent integer overflows [1][2].
> >
> > As the "dl" variable is a pointer to "struct rfcomm_dev_list_req" and
> > this structure ends in a flexible array:
> ...
> > --- a/include/net/bluetooth/rfcomm.h
> > +++ b/include/net/bluetooth/rfcomm.h
> ...
> > @@ -528,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg)
> >       list_for_each_entry(dev, &rfcomm_dev_list, list) {
> >               if (!tty_port_get(&dev->port))
> >                       continue;
> > -             (di + n)->id      =3D dev->id;
> > -             (di + n)->flags   =3D dev->flags;
> > -             (di + n)->state   =3D dev->dlc->state;
> > -             (di + n)->channel =3D dev->channel;
> > -             bacpy(&(di + n)->src, &dev->src);
> > -             bacpy(&(di + n)->dst, &dev->dst);
> > +             di[n].id      =3D dev->id;
> > +             di[n].flags   =3D dev->flags;
> > +             di[n].state   =3D dev->dlc->state;
> > +             di[n].channel =3D dev->channel;
> > +             bacpy(&di[n].src, &dev->src);
> > +             bacpy(&di[n].dst, &dev->dst);
>
> This does not relate much to "prefer struct_size over open coded
> arithmetic". It should have been in a separate patch.

+1, please split these changes into its own patch so we can apply it separa=
tely.

> Other than that, LGTM.
>
> thanks,
> --
> js
> suse labs
>


--=20
Luiz Augusto von Dentz