Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4563-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 13 May 2024 19:12:57 +0200
From: Erick Archer <erick.archer@outlook.com>
To: Kees Cook <keescook@chromium.org>, Jiri Slaby <jirislaby@kernel.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Erick Archer <erick.archer@outlook.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S.  Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH v2] tty: rfcomm: prefer struct_size over open coded
 arithmetic
Message-ID:
 <AS8PR02MB72379B760CF7B6A26A69C5558BE22@AS8PR02MB7237.eurprd02.prod.outlook.com>
References: <AS8PR02MB7237262C62B054FABD7229168BE12@AS8PR02MB7237.eurprd02.prod.outlook.com>
 <d11dacfa-5925-4040-b60b-02ab731d5f1a@kernel.org>
 <CABBYNZ+4CcoBvkj8ze7mZ4vVfWfm_tyBxdFspvreVASi0VR=6A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABBYNZ+4CcoBvkj8ze7mZ4vVfWfm_tyBxdFspvreVASi0VR=6A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8PR02MB7237:EE_|DU0PR02MB9872:EE_
X-MS-Office365-Filtering-Correlation-Id: 8530ca10-098c-497e-a42b-08dc736ff5d7
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|1710799017;
X-Microsoft-Antispam-Message-Info:
	7NmEyfAJOah5olbWzrIJ+fGweCA0YV7ruthuncJx9CV7qsYUaj41a0xlBDKOsk7ss6BN3MbmOmtEuKYzg0IrIDUoRahRmMq8nc1WoYgxk1TM71uyIwdDkOIkSp+/bwcNvYhh4MR7nFU9D/8VCug3q+EHVejO9truQMA6wkYLODIQx3eypSxynVm7wqRB/o/dCMzACBo8IbFd6O9OXUihZTC6TtQetDSIOCsKoqlrCcam7tUd3H9/1S0A0tIzpghLioBIaROYXMdoX332dP39oU48fYf4WNLQdZlhvEqSeUQpMTILiaw2Rh3iPA8aMjzpjBnM/eiWPVYjqfkf0lBwamgY05Ua5wwN9GWU6uOnbK4Ok7tqnEQYB61tIgj3L07QzNniECHGdcqrXlLajAXvdLryWnW7Y+Zanq5ul8c2E1TjuqItlt39469JS8bMu5O6a5mT8AtoOPLMsfft2KIIeM8LeQlu5RMa93cOc0IfegjFEEbtoXaE5BNXInk3M0qu1DcOWCiub7iyycWLlqxAwF5ghxTlebbqMvnpMrGpJM6JatuqCUkwRLlrKmJANbJ+jP8VKVWSWAbM3g5hRzT+0poycEiDZe9QCADuAOGycd+mU9T43myjldwm6W2Qp5gG
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S1ZObEh4eHM1OWdtVGVVWW9oRUJJQ0J0dCtTSXRPS05PYllscVljSGYxZGt4?=
 =?utf-8?B?U2ptVUYzMDNLeWtUb3JRZmxpTldLZjV1amdkc1ZmQnhIdXRiM1IxKzI0ajBh?=
 =?utf-8?B?OHJHT3hqS0ZtdVlnWXdzTFpmRjM5Vlg5ODZBZDB6RzV2Uzd4NUpVYWVueklr?=
 =?utf-8?B?ZXF6UmttTFdydGkyUncvUnI5RExwZFNwSmlrdmJ5bGRXRURnTGE4cEpranBZ?=
 =?utf-8?B?SUhUcEZFaEpHM21PZndpRGthdm92ZzJUZjRyOHhWNXVtTng2UFlER1UvUGxP?=
 =?utf-8?B?LytITDBiYXg1QTY5UUpEenJmNmY5aVVJRmhuMytNYkVpcUI3dk5EUjVYL2hC?=
 =?utf-8?B?MzBxbm40Z25udGhFcUsyQzZ1Y3Y1Q0tjNThhbUdZZW5iM2RTcnNwY2RwVmhh?=
 =?utf-8?B?NGxSVkRHWGJ2L0V5MS9DUUszelkyQUJHN24rdjhSeFk5UWwvc0FGYitWUWNP?=
 =?utf-8?B?WnNWYndTSnZHS1doWWJOQzNpQ1J4S0lMekgwQ2wvWG9KbExrQnU4MENTNjlk?=
 =?utf-8?B?eVBRaFVtR2pPZDN3bGQwQTRicUEwamhOUjV5WUNFWU1QYWVuQ0lpcy9MTkNB?=
 =?utf-8?B?WW9NWUx2SGJuN0RQUS94bFp5ZlUrV1p5a2JqSG1NeFR3djMrd0h4QTlwVTda?=
 =?utf-8?B?ZjVIRXhDYUFvbXlhMjdReVJ4UnJzYk83ejIrQnc5RnRlUFNSL0ZpM1dNU1FZ?=
 =?utf-8?B?SEVpcGwyQmZ3MHk2MU0vVy9nV0FnSVJ0VTNpMGNmWFQ2SnRsWVk4anJlOFhY?=
 =?utf-8?B?Yy9GdE0zaE9nNTNDT1Voa1pYWWdhU1lhcHVHQ095eTB3M3ArV1JWUW1VNFZM?=
 =?utf-8?B?bVZ6alQveDR5S1YyQ01XYTQ4VWZ0QlBrREROTmNkdGpTdG83TEN1aUZNN2Jv?=
 =?utf-8?B?NkkrUUlkUTdaY0pnKzhONEUzNzJiZ2dKYWFSZnRuVEx4SkFvSG9RNzVBbTFr?=
 =?utf-8?B?ZGxkKzFxeU90UERNcndqUEN0cGhLKzA4L2Z4V2x5YUdCd21ndmU5c2hwUkpK?=
 =?utf-8?B?NlZQRUpUTjBRaVdwclI2Yk9lbk40bm1ZQVcxMnJaTzNnTFF2OGU1YUQycmoz?=
 =?utf-8?B?bHVEem0xMlJGb1luemxzZUNibC83WjQxK3R3LzBSWi9JdnRENkVhU2F0SXhk?=
 =?utf-8?B?UUVVcDk1U0lOZTh3ZzVlMlBTRjdGK1hGNEk5b2UyeXUxWDQ5QUNTay9va2FV?=
 =?utf-8?B?L0w1MzRjWThyM0d0bDI3WUIxTXhFQURYa2NrTGcrb0UxeXFHL1lOUnZoUlVU?=
 =?utf-8?B?eG5JNnAyc0lTUnpPVVJiSzhRUUNLNkd6bjlPbHU5dnJlQVZ3SE1GWEV6T3dN?=
 =?utf-8?B?Mnd4NFcwWndFTThvNWV6MC9sRk1SN0JFZjIrR0hZRGRCQVQ2bS90NTlqMzg3?=
 =?utf-8?B?Z2lHL3EwYzE1d0RrVktLaTJXWGdBWlpwMTdRWklwMHJNcTU3aS9EYzFuWWha?=
 =?utf-8?B?ODJJc21hNnI5bWJPQmtrRWJCQitGWk9tbVVXdFpQaUJoYXVrM3Q1OG0zY0NQ?=
 =?utf-8?B?OGxJbzZObFVYeDNqM0hnWHVLVVZ5TytZNmxiZXByNnRjeFBER0x4eXdNK3p4?=
 =?utf-8?B?cW55bExhbjVOMjNqMzRSNElFeVF2cThWWE8zWXZGR21wL2s0Z2E2Yzhvb21X?=
 =?utf-8?B?eU9WWEx5REozQmE1M0ZyNWZ0ZE9lNzdZVllQMStMQTR5Y3Rvd3lsUG1HanFa?=
 =?utf-8?Q?YfQdsbfW7aJC5khD7YD2?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8530ca10-098c-497e-a42b-08dc736ff5d7
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB7237.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 17:13:08.4833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9872

Hi Kees, Jiri and Luiz,
First of all, thanks for the reviews.

On Mon, May 13, 2024 at 12:29:04PM -0400, Luiz Augusto von Dentz wrote:
> Hi Jiri, Eric,
> 
> On Mon, May 13, 2024 at 1:07 AM Jiri Slaby <jirislaby@kernel.org> wrote:
> >
> > On 12. 05. 24, 13:17, Erick Archer wrote:
> > > This is an effort to get rid of all multiplications from allocation
> > > functions in order to prevent integer overflows [1][2].
> > >
> > > As the "dl" variable is a pointer to "struct rfcomm_dev_list_req" and
> > > this structure ends in a flexible array:
> > ...
> > > --- a/include/net/bluetooth/rfcomm.h
> > > +++ b/include/net/bluetooth/rfcomm.h
> > ...
> > > @@ -528,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg)
> > >       list_for_each_entry(dev, &rfcomm_dev_list, list) {
> > >               if (!tty_port_get(&dev->port))
> > >                       continue;
> > > -             (di + n)->id      = dev->id;
> > > -             (di + n)->flags   = dev->flags;
> > > -             (di + n)->state   = dev->dlc->state;
> > > -             (di + n)->channel = dev->channel;
> > > -             bacpy(&(di + n)->src, &dev->src);
> > > -             bacpy(&(di + n)->dst, &dev->dst);
> > > +             di[n].id      = dev->id;
> > > +             di[n].flags   = dev->flags;
> > > +             di[n].state   = dev->dlc->state;
> > > +             di[n].channel = dev->channel;
> > > +             bacpy(&di[n].src, &dev->src);
> > > +             bacpy(&di[n].dst, &dev->dst);
> >
> > This does not relate much to "prefer struct_size over open coded
> > arithmetic". It should have been in a separate patch.
> 
> +1, please split these changes into its own patch so we can apply it separately.

Ok, no problem. Also, I will simplify the "bacpy" lines with direct
assignments as Kees suggested:

   di[n].src = dev->src;
   di[n].dst = dev->dst;

instead of:

   bacpy(&di[n].src, &dev->src);
   bacpy(&di[n].dst, &dev->dst);

Regards,
Erick

> > Other than that, LGTM.
> >
> > thanks,
> > --
> > js
> > suse labs
> >
> 
> 
> -- 
> Luiz Augusto von Dentz