Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2551381lqo; Tue, 14 May 2024 02:04:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUevBlbgSvll6tn/YyCacOeD3rGTLm8bdgrs9qMioGq9h3z7w1/rkdz1py+C3ZQ78o97lX1Nb+rz88SI4P1yP9O4AgrZOpA65bgoN85Q== X-Google-Smtp-Source: AGHT+IGRaEO/54WpQetwXHZVCceJUrAaARexVupIdkeptpOSBm/Z6gjNh28of78QXStP+EaQypWG X-Received: by 2002:a05:6870:d153:b0:244:ba40:8b29 with SMTP id 586e51a60fabf-244ba409c58mr9790519fac.43.1715677479230; Tue, 14 May 2024 02:04:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715677479; cv=pass; d=google.com; s=arc-20160816; b=OfSYcnoyuFFrexb+EdW5XbsTL2q8A5sFzpIwQHY+HYcMpeWHjeVy+8iP0kcIryNh1P tDAdZw/YrcXRjuuk3B2Pohwf2PqfF3pTCAUuPOssxXjvA39nQAQEc1DMMoDDjdmGfh97 ihISft9n8ktnjMebjm9zYyTMgPgLO3LHMfp8ofWs8Pz4vhfcKZ+HLtmqrqDU7iN4F6Ve ZurLuoI/aLAg7vEHTos4EzO8GmC4MKNHPUVJDPyjwlMEPjVKp1w4ceDLWDDq3z/yuz5R yJ70Plv3tRuDEva10Hff4ACe6+XvuiNh+dIYhZwOto7Ig+I3e+d/vRMHqoxtBIuI7hAH Mn1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=2sGkO49KLFONWfFdi6QmW1EeesHZpy/3bqd+R/nBwTo=; fh=jQ5WhQ7D240g5cMA531jgN8TDQBEvBFiS/zbNVHHlic=; b=vIC99oTdoEYnSSNBYNko6G6cCnpchHu0Do83AmEBor6SIuSH1eUs2Aumy50MZnBHXK zr4XrCnZPkd1nyDtjUEdmm5r3rAeEH5EbaRv0ogBWPgHtPK07qbB//AwMZZHVBMiMcIN 99AyMQjH9l6psx6oo4VPTKh+ywrT6YZQQmFLHskFU38iIQN2bLLMZucfgokygNm5zfMp eIQF8YcFJxnMBR/N/gV2vVjl6gedwQ44mu565gFHhdMwAbCdumOp0F7gq3rre5aryXMZ aNh/Yp+ON0/OHPPBKi6c8PzzA2SLcSEI58VjcPbE6ERagh6ptHuBMYwO2+OVN/OfJ+H/ LqZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-bluetooth+bounces-4588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4f95e4d60si5220949b3a.236.2024.05.14.02.04.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 02:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-bluetooth+bounces-4588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 51269B21AC6 for ; Tue, 14 May 2024 09:04:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C243B23763; Tue, 14 May 2024 09:04:25 +0000 (UTC) X-Original-To: linux-bluetooth@vger.kernel.org Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF96FC1F; Tue, 14 May 2024 09:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.121.34.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715677465; cv=none; b=B42bCzeL4Cdb7YIHqPZCdSfvvyRFwTum1zRZH2K191nI6CqvwoY1FL18Ohu2HbpQkANjGcl798t73h+ZKFVrQU2/2ymmQPYhGTTWFWtvoOfzjDreb6FJM5IvbHI6sFFEOFOgyTtTxCG1Y2vTa1tMPUcTLiX0z+kQfMyQHjcA1x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715677465; c=relaxed/simple; bh=DN8MJhZE/6ABuaOgDNbrslUWBDHWkr4DQN1q02HGp+I=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=byFJGfOmwmMNDGXg+VwQYQbQD3c6pOmaPR2mivs209D3dH26HlGfXH3BHOFjsavvJtYfgaZZAJ97x/41MHr7iCj5SZU/dxnPs2nY/NhQK7Ihcb5hoqG03jGUzlIgfxcKzEb9ouds0Bt7OG+BoDEjOGBTUJ9jYkQxpG4bCIinTio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; arc=none smtp.client-ip=92.121.34.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id E3F461A1D80; Tue, 14 May 2024 11:04:19 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 9CD211A1D42; Tue, 14 May 2024 11:04:19 +0200 (CEST) Received: from pe-lt8779.in-pnq01.nxp.com (pe-lt8779.in-pnq01.nxp.com [10.17.104.141]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id BE3EE180222C; Tue, 14 May 2024 17:04:17 +0800 (+08) From: Neeraj Sanjay Kale To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, amitkumar.karwar@nxp.com, rohit.fule@nxp.com, neeraj.sanjaykale@nxp.com, sherry.sun@nxp.com, ziniu.wang_1@nxp.com, haibo.chen@nxp.com, LnxRevLi@nxp.com Subject: [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup Date: Tue, 14 May 2024 14:32:58 +0530 Message-Id: <20240514090258.1507934-1-neeraj.sanjaykale@nxp.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP This sets the default power save mode setting to enabled. The power save feature is now stable and stress test issues, such as the TX timeout error, have been resolved. commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in power save stress test") With this setting, the driver will send the vendor command to FW at startup, to enable power save feature. User can disable this feature using the following vendor command: hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE) Signed-off-by: Neeraj Sanjay Kale Reviewed-by: Paul Menzel --- v2: Corrected subject line. Added commit reference. (Paul Menzel) drivers/bluetooth/btnxpuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 7f88b6f52f26..42e929f0d141 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE]; /* Default configurations */ #define DEFAULT_H2C_WAKEUP_MODE WAKEUP_METHOD_BREAK -#define DEFAULT_PS_MODE PS_MODE_DISABLE +#define DEFAULT_PS_MODE PS_MODE_ENABLE #define FW_INIT_BAUDRATE HCI_NXP_PRI_BAUDRATE static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode, -- 2.34.1