Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5aa68ee5-dd84-4ac2-9fd1-36160358fdcf@molgen.mpg.de>
Date: Thu, 16 May 2024 07:44:44 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bluetooth: btintel_pcie: nonsense error recording in irq
To: Oliver Neukum <oneukum@suse.com>, marcel@holtmann.org,
 luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
 linux-kernel@vger.kernel.org, Kiran K <kiran.k@intel.com>
References: <20240516045118.18552-1-oneukum@suse.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240516045118.18552-1-oneukum@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

[Cc: +Kiran]

Dear Oliver,


Thank you for the patch. I have two minor comments. Could you please 
word the summary as a statement by adding a verb (in imperative mood). 
Maybe:

 > Fix nonsense …

or

 > Remove unused `ret` assignment

Am 16.05.24 um 06:50 schrieb Oliver Neukum:
> Either you return an error or you ignore it.
> Recording it but then overwriting it makes no sense.
It’d be great if you added a Fixes: tag.

> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>   drivers/bluetooth/btintel_pcie.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 590c188a4bb3..c507422d6b1b 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -498,19 +498,15 @@ static int btintel_pcie_submit_rx_work(struct btintel_pcie_data *data, u8 status
>   	rfh_hdr = buf;
>   
>   	len = rfh_hdr->packet_len;
> -	if (len <= 0) {
> -		ret = -EINVAL;
> +	if (len <= 0)
>   		goto resubmit;
> -	}
>   
>   	/* Remove RFH header */
>   	buf += sizeof(*rfh_hdr);
>   
>   	skb = alloc_skb(len, GFP_ATOMIC);
> -	if (!skb) {
> -		ret = -ENOMEM;
> +	if (!skb)
>   		goto resubmit;
> -	}
>   
>   	skb_put_data(skb, buf, len);
>   	skb_queue_tail(&data->rx_skb_q, skb);


Kind regards,

Paul