Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp266941lqo; Thu, 16 May 2024 06:01:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFJsJzJHTPzMuSpxIg6WGcqVv5TkaSmVnGeaXkp7BzPLHWogKHEEIY9hSuc0LS0EDx3816LBaBYVpVdkEdD3yE3etAvhM5Cq7SBuau5Q== X-Google-Smtp-Source: AGHT+IG7lCYDLYK7/XA0PpCG573UrfYzOjoj3fE+dIVvZftn0IOIZWBlxlh1ZPWmZ/sOg72j4UkE X-Received: by 2002:a1f:f802:0:b0:4d5:f28b:2c2c with SMTP id 71dfb90a1353d-4df790952f4mr15800602e0c.3.1715864471771; Thu, 16 May 2024 06:01:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715864471; cv=pass; d=google.com; s=arc-20160816; b=L2AFwImFCFau1juU7Pfg9dMWjBBNrrAdGKoIzisLdyFnzbnxi0Si0R4oe86FoV5RP2 1zP4mbG9Hz55VYX1fPdB3Q+dU6YhmveK7MGRkr1CE50EDWBRbRHqak2bLFUfzqyrjUS6 zFWDRHTW6OjHc0ltxiP58LJ47Q/boir6jNUUHnIPf5sRGnfYy7vtPN+PcKwdtuDu+ADe VALeuPwDU8Wo0ctxoAl2CdXT6GyJvisQwPcS0QGMq8YzzKQnBEXjqR3jEzUBsh//lByl 1p2qEYCCXDSi20DefH2cRe3AO42nDHNwo+F73uF8YQL9X181yFQ9sUDeaqCQDPWP5pxM 6a8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=H/sO9HdSr7X8ew5pRRoUjGKRMwlhq3dRfLeeCDTKl9k=; fh=WXsZyY/x+YscnlXYh6gpbeRG67RX5X7VxusCESrtG4o=; b=gEh8h4D3y3PCFbveYe4iUgQy9QalhMRvYU2R4TB0CDNSz1JPIu2DZVNNa2V763rCSA 6OMxHOf6QYQiwrHqSCbqkjkKvTs1f0BP5pczOX8p6EDiIdGaeDE2yGrdvYZvU9Xm5NFo vtuIRTugubZNtC2C0nRcfWfrXdndzi+Ovd4K/9qKyfR68pmPKZEN/ESc3ThOKeLfPy9g 1TkBznxAKdt80nY6mMQfeQBa8WBp0uwNBi/Dkx08gCHX8KC4fEzrqW4r7VxmJyW/J/5m C9hO02Vbgyo2UGnFkkjo2v6K/pST3FBawDaDyIe+qtIuHxQe8O3EXuKoS6f4n3XnXO9i A9oQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NcwFgYsr; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-bluetooth+bounces-4709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4709-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 71dfb90a1353d-4df7c0a9b23si2738181e0c.286.2024.05.16.06.01.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 06:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NcwFgYsr; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-bluetooth+bounces-4709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4709-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3F38A1C22010 for ; Thu, 16 May 2024 13:01:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C84EE146D76; Thu, 16 May 2024 13:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NcwFgYsr" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA11414658E for ; Thu, 16 May 2024 13:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715864457; cv=none; b=PNkSimwEUi+fYBhqUHseqLv4JRtwrnmxxAdtToGaC81+OtZg2w38qB2C5HdRov/j5tZyLW6IkxcBNReTSBAAaDidxSNd83ieU25YwrgpPDnFxxC4BlxW7kAHEt212QWefbBYODoFIwyqfXdSSz6/n1WD7J9bbXlpoYGiTFmC/MA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715864457; c=relaxed/simple; bh=UelzzseOVEb5xnEvTVZqUl1Wg2Y8s5/14CVh7FmByKc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XssINKF4DoaslMBQV8ATBPato9tdq5rgFW++2N6yFsmLtpbzNHW9Zzjcy1a4/t8O2z3l8DvPVHlNGBh7Gj0SO7oWJGTU/ZGFASP61xcU7fOt4IYupFliYVzgc1wS+hVYH7P14BDIyerErGi5KsYKyBWzQS4q9oM064Ue3TIm3EU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NcwFgYsr; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715864455; x=1747400455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UelzzseOVEb5xnEvTVZqUl1Wg2Y8s5/14CVh7FmByKc=; b=NcwFgYsrBtpqE4Fv4rPFhZK0l6n29kFx672ro0SSTmnZebAn6sZ1P0Nh ClIShpOKHM46HNk7meVQx2gD0chNOQVEhB0jxGdPpuG8X1eN6jqIioYiT Aq/XZe3yMNM8gJiJJVIylgU1Rn/ymLaSskFGqsEAgJ4z6pMqY7or06RMj sLPOaaTt3SbSWZD4Z0Yl+k/ICqXWrSBKxThF0QefK26zPXrhcNLf1zvEf QoyVmbRY3fLa4QpUHkhTKP8+uFU2RtzgJGGhcFjnXJov8fsoHWq2427rB DJDLnKBMw2GugqTKzx9Lp3RE8pN1SeFGEAUe0v+Ya7nOT96pc6JyeeKii Q==; X-CSE-ConnectionGUID: Vxx1uErKSBW3oUO+I3U3EQ== X-CSE-MsgGUID: L9t4BmECQRiMCD6IuSsK9w== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="23108551" X-IronPort-AV: E=Sophos;i="6.08,164,1712646000"; d="scan'208";a="23108551" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2024 06:00:55 -0700 X-CSE-ConnectionGUID: OU6ZoC5eRz2okfKmOYXb/A== X-CSE-MsgGUID: iEXJhYNPQoS5zrrSmid/8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,164,1712646000"; d="scan'208";a="54623627" Received: from intel-lenovo-legion-y540-15irh-pg0.iind.intel.com ([10.224.186.95]) by fmviesa002.fm.intel.com with ESMTP; 16 May 2024 06:00:53 -0700 From: Kiran K To: linux-bluetooth@vger.kernel.org Cc: ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com, vijay.satija@intel.com, Kiran K Subject: [PATCH v2 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue reported by coverity Date: Thu, 16 May 2024 18:45:10 +0530 Message-Id: <20240516131510.904787-3-kiran.k@intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240516131510.904787-1-kiran.k@intel.com> References: <20240516131510.904787-1-kiran.k@intel.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vijay Satija check pdata return of skb_pull_data, instead of data. Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe transport") Signed-off-by: Vijay Satija Signed-off-by: Kiran K --- drivers/bluetooth/btintel_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index d8f82e0f6435..58144c82b1cb 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -382,7 +382,7 @@ static int btintel_pcie_recv_frame(struct btintel_pcie_data *data, /* The first 4 bytes indicates the Intel PCIe specific packet type */ pdata = skb_pull_data(skb, BTINTEL_PCIE_HCI_TYPE_LEN); - if (!data) { + if (!pdata) { bt_dev_err(hdev, "Corrupted packet received"); ret = -EILSEQ; goto exit_error; -- 2.40.1