Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "K, Kiran" <kiran.k@intel.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
CC: "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>, "Tumkur Narayan,
 Chethan" <chethan.tumkur.narayan@intel.com>, "Satija, Vijay"
	<vijay.satija@intel.com>
Subject: RE: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue
 reported by coverity
Thread-Topic: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue
 reported by coverity
Thread-Index: AQHap4wgIzWqHInHzUGt/5hlU9MTx7GZ03Aw
Date: Thu, 16 May 2024 13:03:17 +0000
Message-ID: <PH0PR11MB7585A340F55F0B7C1961B18BF5ED2@PH0PR11MB7585.namprd11.prod.outlook.com>
References: <20240516123938.891523-1-kiran.k@intel.com>
 <20240516123938.891523-3-kiran.k@intel.com>
In-Reply-To: <20240516123938.891523-3-kiran.k@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p20//X648+m3dlArOeqjWeLxsKRv5rxpREk11NoC06GSsr67t1hwbA0WMmBt?=
 =?us-ascii?Q?D/N6qxywmNWXlsKAAPVIFSS8SJqeAC3Dzg8wEGhAuA6JMSjamIFvipbdbRXr?=
 =?us-ascii?Q?6VHHN6hZRI7G4EodjlRP4LE1OksMz1dk0nkbzJ1JDPDhn8gUFOT38bmZkvyl?=
 =?us-ascii?Q?ZsXC8LUqCtpaRy3RvuGqLwuWOUaucjrzhssgPP87SRJdqcEAItbXX1Bzp0y6?=
 =?us-ascii?Q?XasRym+ArNrAh31Yll/DLal3ux+Nx3iTDFe6Q1+hFmxTQZLq8Xnhllau+XCf?=
 =?us-ascii?Q?Av3MMrpbPDrMsdNV+9rp2X3j7M3aXAVtIqBMx/iGw80xkbogLXnOs4Jyq+KT?=
 =?us-ascii?Q?UQNcNeoJBnnZSbHRZ9y/oDV+kUcxh+JavQZ7IajMPR9/KP2x9qyrpwtMMyuZ?=
 =?us-ascii?Q?LSlF+dSzeUm7dv6+cJh5pm3jZBHlJ7p2lftuQTAolpCRqdIbznEVopkIIQr5?=
 =?us-ascii?Q?pE1QvRqbQnmUIpJzA2xFRb+nZssDyam76x6dUfwgHwtjzdkD6V/bjNjbeX5Y?=
 =?us-ascii?Q?lcZI+3W/QNvpVv/z2ELZ/D5T8+WiN33NAiXlPfmkIS2QkuzKgyTAUhYNuOGz?=
 =?us-ascii?Q?/cr1bVWczhe9wsVvgwehX2czJTHxfVpG4e21TWLpJlQhp47cGVEouZcr+XuJ?=
 =?us-ascii?Q?SR9Tg+rY3hXSVqrIrhIWkxctyFbJEe8TjY5gykMlMDT71102o7p/Q3P9/XfN?=
 =?us-ascii?Q?yQhjTbWzeh1fzvJXqtdnFtPxhR500o8hvNVAh1YvcBiDcRPLFpKr8QUN4q3j?=
 =?us-ascii?Q?fi9A2rQIcZKiuuG39+s0hLGKiD4fZ2xqcizqR83Jjg2NIrJr+GISXJzPzfOo?=
 =?us-ascii?Q?ReYqjmqrYg1yw8H/eJ4WmdOpfNKQUGslkC6cCV3KvoB7NcpV7xNhpGPKQlmv?=
 =?us-ascii?Q?kHdgSC9/c8k2mkcNrLrZMNTIKoaBrlsZ2CuKO7nb9cGE6WIXCk5B+d+TmXfR?=
 =?us-ascii?Q?uPUD3qoNspBPFrFUF2tksDoK0+hXbOEMTCDpUaniuU/0607TSiWIP2JiMqSl?=
 =?us-ascii?Q?tHMeVhX9zzqU7/igh6Zm52jQ1IxOlhocCl89k65sXRQttxg4Sg0+/M99dikp?=
 =?us-ascii?Q?Vf4GgMxKmY9UFUmsaJ5i1qbb0pxHsRnWStfJ3sboAw5UVqNE4IPnK4Ko1GFl?=
 =?us-ascii?Q?//0VAtwlNNaeTEik8dDgKUhd6h2PQMBZmcuXi41mbEFFskXgISmzjhM51zZw?=
 =?us-ascii?Q?64PDWG8p44noLogo/q7Bp9utcW9d3tsOA7OpefAgT5XUz8+lw9ufw1/QmfD7?=
 =?us-ascii?Q?Px8BpTxgCeaByQpOfX0F6uT9l2wXfL+vsRZc6mthSQ6pTeYFplGBV9nU68Me?=
 =?us-ascii?Q?z/klE+nBTuwIWD7p4LYQCZU2U0XQiZp+5u03hmCHSofAw2nYY2dsumCT+C22?=
 =?us-ascii?Q?wUH3bpLFa73LpPdkSvEQRqBy+3OACHxS0U+00OJEd02cWi94tVaZxHOcShuT?=
 =?us-ascii?Q?V9NKFwtgZd1CIq5IwYFXZGULwKOC7Z3WQyEb468FwpgR4rziLP6hVcM5dXCO?=
 =?us-ascii?Q?0l51iPW7hdEPg1G0ayckTjVimHjK6JCxp1V3S6yy4I831AVUpKAoytZjVDmn?=
 =?us-ascii?Q?tEh54yvTKYJwHHwmLbU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-bluetooth@vger.kernel.org
List-Id: <linux-bluetooth.vger.kernel.org>
List-Subscribe: <mailto:linux-bluetooth+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-bluetooth+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7585.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 148097c2-a4c7-42bc-8941-08dc75a88e50
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 13:03:18.1905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VxzVPnKn4ArInt+5UNfvLui3B97pHvM5xNFhW5kE3TzfwwRGd2X6jh+1yUUy+NTtfDY6ScSrOFYO2c5zPgSkaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7251
X-OriginatorOrg: intel.com

Please ignore v1 series. I have published v2 version with Fixes tag include=
d.

Thanks,
Kiran


>-----Original Message-----
>From: K, Kiran <kiran.k@intel.com>
>Sent: Thursday, May 16, 2024 6:10 PM
>To: linux-bluetooth@vger.kernel.org
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@intel.com>; Tumkur Narayan=
,
>Chethan <chethan.tumkur.narayan@intel.com>; Satija, Vijay
><vijay.satija@intel.com>; K, Kiran <kiran.k@intel.com>
>Subject: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue
>reported by coverity
>
>From: Vijay Satija <vijay.satija@intel.com>
>
>check pdata return of skb_pull_data, instead of data.
>
>Signed-off-by: Vijay Satija <vijay.satija@intel.com>
>Signed-off-by: Kiran K <kiran.k@intel.com>
>---
> drivers/bluetooth/btintel_pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_=
pcie.c
>index d8f82e0f6435..58144c82b1cb 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -382,7 +382,7 @@ static int btintel_pcie_recv_frame(struct
>btintel_pcie_data *data,
>
> 	/* The first 4 bytes indicates the Intel PCIe specific packet type */
> 	pdata =3D skb_pull_data(skb, BTINTEL_PCIE_HCI_TYPE_LEN);
>-	if (!data) {
>+	if (!pdata) {
> 		bt_dev_err(hdev, "Corrupted packet received");
> 		ret =3D -EILSEQ;
> 		goto exit_error;
>--
>2.40.1