Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>, "marcel@holtmann.org"
	<marcel@holtmann.org>, "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>
CC: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Amitkumar
 Karwar <amitkumar.karwar@nxp.com>, Rohit Fule <rohit.fule@nxp.com>, Sherry
 Sun <sherry.sun@nxp.com>, Luke Wang <ziniu.wang_1@nxp.com>, Bough Chen
	<haibo.chen@nxp.com>, LnxRevLi <LnxRevLi@nxp.com>
Subject: RE: [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on
 startup
Thread-Topic: [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on
 startup
Thread-Index: AQHapd3Ck6iBL6ukvEC45Bem6IEoArGbCLQQ
Date: Fri, 17 May 2024 07:17:56 +0000
Message-ID:
 <AS4PR04MB96921A132C1F767792609323E7EE2@AS4PR04MB9692.eurprd04.prod.outlook.com>
References: <20240514090258.1507934-1-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20240514090258.1507934-1-neeraj.sanjaykale@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?d0ZJ+k3yJRIofoBHl8ZEax21Yiz16P8ssvB0+MurSDqAuznQQOV/nj1/K1Ry?=
 =?us-ascii?Q?vr1W7Cb3Atp/1BDpuzGdTyP/kIXwip+N3fqLarOD48tYyMQbhkagquwXXCMW?=
 =?us-ascii?Q?keJ9L7g12/4XrmCcPV776U7niaFVmCNuEaYama/uesPgeMpfQQVosw6yBzyv?=
 =?us-ascii?Q?kZwwnCe960fGnZ9JuT26WX+8by7d1VEAIQz2aq2OgOgj7cTJ4yCerZ2mahzY?=
 =?us-ascii?Q?YAJR6dmhZVGTV59qZq3grqlLrZ1xuwqjpBNNMPdT7XMhkxH6tP1HyiCV21Os?=
 =?us-ascii?Q?M69gFYGhb95YWiM6vh3pnoZiJNqgbwzBd8vRgWra/zM0jtmLsuIHtmHPSIp5?=
 =?us-ascii?Q?HTB4q/dCwDKWEg9iKDdxu4FBkjiZJYSZn0rXURZlHtVXll6hc24DLAKlgbTo?=
 =?us-ascii?Q?9oWtsNOzzf1Nv07QuSIxKvN4lvxYk/zw3gqE+6DMdt8obU8w33jVTrRkAmUq?=
 =?us-ascii?Q?NHobOBC6hmyaFErNlPxp+j59G+wJ/EM1v3MdKAOYQGsSb9FHhwqj2bLniwBt?=
 =?us-ascii?Q?r0vkRvcvaqJwkGEhfKU4QwamLeBDoQUgfRGyN7NLkbdfUk7Nip+JXTi5ivr6?=
 =?us-ascii?Q?MONYAK2LxWIadb/Qfb4BTH+UFxQ/Xl/1wbibgpnXIbFsnHgGJzDFpSn8Q9y+?=
 =?us-ascii?Q?YhsVM20faV2qQ+RYH/FtaCo4+97D8JCcEhjjXHpZ+q8qrdriBIbgrXSdjzmm?=
 =?us-ascii?Q?E4bepQIBwY0q4JFMHElW5aelQnB57OoHA/oATrka+fgGdJWxBrKk36Gq04EM?=
 =?us-ascii?Q?IVJOU0ORlYEIk774j3vVZPXm1R49eorkY/oeH6Hd7ZoZfEUlXue7+MK2ohgz?=
 =?us-ascii?Q?fLFet95ZpZAD6SwT71fGuHGyQ94O001J1/Swvo2Kz+pnGJj3x9mZrYxbAh7t?=
 =?us-ascii?Q?Bk94TOCo+G9PzqOSIcFU+RQQcjczBYdszECJBxYd61s8JrQ7O3luO74+GclH?=
 =?us-ascii?Q?VwxV+QSVdpJp+uIMJzC32dzjmbehoiWpwOq19nseSZjOa88t+lPRVwKw3E/z?=
 =?us-ascii?Q?I0bMQ+NwXvvS3ipi/y0VXIcIa6uQVvUB9oH/xUkFSTtbXfP2tjxaBMdepTcP?=
 =?us-ascii?Q?QU58s32TsBoa6UrionYyz6MHeMHWXXmNr1xP7TPFkavYhxJXaqM3WIXJUNrO?=
 =?us-ascii?Q?I2PyGmHJZtBwgaM19K12QdeNmc+6uIETiF2e/zJZ/WCqmpfcDZ2OHLovUBTY?=
 =?us-ascii?Q?fHBSLazK8G+j+24SrbR/CsOM6DDBTorPNdV40JInsCYGBt1sfgwzKBjpvbdw?=
 =?us-ascii?Q?zpkfiW/5JzeLxnoPWv8Qv8R9V27V0BjVdvHUk7MZS8UcT9Hmbo+buJswK1GI?=
 =?us-ascii?Q?T3pZbnqyuyBJdfKen/j89oxSimldMjPd25iK6AH3yXXl8ryOVL/oUT2kX9I4?=
 =?us-ascii?Q?PELMlomvCnNnV8txpSihNTgrhQYVx9hu0jqFwds3ZhuXNR7t7mK5C0AlP4/z?=
 =?us-ascii?Q?Xx5CMgcQWgc+usGFqNN7fZGKIQDfmPm/656/Es7pHMhG18Hh9YDc9J6ir4qn?=
 =?us-ascii?Q?VsoV7iwNr7Hz70P8lFu/sRKi1/kzX+g62qcAOFZAOyeXwYesUsf7bVBt23Kz?=
 =?us-ascii?Q?IAG9rwqa/eMM/9ij5E2HE3sU/PRQiTyZHEegyodW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-bluetooth@vger.kernel.org
List-Id: <linux-bluetooth.vger.kernel.org>
List-Subscribe: <mailto:linux-bluetooth+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-bluetooth+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9692.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99069223-3339-4b6e-aed1-08dc76417991
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2024 07:17:56.3813
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: COpHj45/lnmi6N187lS14XNnR9wqhYTiyjDXboGDH45/g0UHLjinC4AXjMJeTdTiPUksaTwmo9rZLaeQQj6s9eacy1K/HnksJyFmTIX5lHQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7419

Hi Luiz,

If no further reviews, can we merge this?

Thanks,
Neeraj

=20
> This sets the default power save mode setting to enabled.
>=20
> The power save feature is now stable and stress test issues, such as the =
TX
> timeout error, have been resolved.
> commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
> power save stress test")
>=20
> With this setting, the driver will send the vendor command to FW at start=
up,
> to enable power save feature.
>=20
> User can disable this feature using the following vendor command:
> hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)
>=20
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> v2: Corrected subject line. Added commit reference. (Paul Menzel)
> drivers/bluetooth/btnxpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.=
c
> index 7f88b6f52f26..42e929f0d141 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];
>=20
>  /* Default configurations */
>  #define DEFAULT_H2C_WAKEUP_MODE	WAKEUP_METHOD_BREAK
> -#define DEFAULT_PS_MODE		PS_MODE_DISABLE
> +#define DEFAULT_PS_MODE		PS_MODE_ENABLE
>  #define FW_INIT_BAUDRATE	HCI_NXP_PRI_BAUDRATE
>=20
>  static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode=
,
> --
> 2.34.1