Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <69ebe55f-0c2a-472a-bb4c-17731e48bffe@molgen.mpg.de>
Date: Fri, 17 May 2024 12:12:05 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/3] Bluetooth: btintel_pcie: Fix irq leak
To: Kiran K <kiran.k@intel.com>
Cc: ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com,
 chandrashekar.devegowda@intel.com, vijay.satija@intel.com,
 linux-bluetooth@vger.kernel.org
References: <20240517095447.956132-1-kiran.k@intel.com>
 <20240517095447.956132-2-kiran.k@intel.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240517095447.956132-2-kiran.k@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Dear Kiran,


Thank you for your patch.

Am 17.05.24 um 11:54 schrieb Kiran K:
> Free irq before releasing irq vector.

Can the leak be detected somehow? How did you detect it?

> Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe transport")
> Signed-off-by: Kiran <kiran.k@intel.com>

Just a note, that your surname is missing too.

> ---
>   drivers/bluetooth/btintel_pcie.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 8d282ee2322c..d8f82e0f6435 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -1329,6 +1329,12 @@ static void btintel_pcie_remove(struct pci_dev *pdev)
>   	data = pci_get_drvdata(pdev);
>   
>   	btintel_pcie_reset_bt(data);
> +	for (int i = 0; i < data->alloc_vecs; i++) {
> +		struct msix_entry *msix_entry;
> +
> +		msix_entry = &data->msix_entries[i];
> +		free_irq(msix_entry->vector, msix_entry);
> +	}
>   
>   	pci_free_irq_vectors(pdev);


Kind regards,

Paul