Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4766-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/5] shared/bap: Handle NULL caps at bis verify
Date: Fri, 17 May 2024 15:34:32 +0300
Message-Id: <20240517123436.146332-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20240517123436.146332-1-iulia.tanasescu@nxp.com>
References: <20240517123436.146332-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/N7cKKd9oKN005877Z2pblSxpTedRiKuWiQbaH5MSVH7aofSUFaRkwU6qx6Y?=
 =?us-ascii?Q?S9rBQoZyv3WWw5eOVkzcn/4kUje7rCIVsxiAYe52KjRewrdZqiGBR+PsnZEI?=
 =?us-ascii?Q?vAbyLH3zDnmTtm/N8qw42UoT12kO/fXRXDJvjfbPDXF81mvnzI3wYNjl3j+E?=
 =?us-ascii?Q?bF+vL+3N4UkwS/OSVXymFceYiTeWTAR/etV6HS2BkJWE83weuZuP81ITagcl?=
 =?us-ascii?Q?ummXeXIkz7zyFQX2kqtKJJ1W9VHrYhG5LanA/i/JN2cWY3pBlFxZAMHk3BCO?=
 =?us-ascii?Q?uHCf0tvcfJR1ZjuVQz5xbeokuFHsXeCx+QTcYHyywkQkfgSEFXxOmmt1qULH?=
 =?us-ascii?Q?+/vpQAx/0Z2CbsS+af+XWoFFbBjLJ47lwkY6Jg6Vpqm9A6IgSWaxXJs49aHg?=
 =?us-ascii?Q?PiyLcj+z4zz4MpxUedXS5Qd1zAEyph48O33qAG4H0dxxtTiGit0XCMy4Ldxr?=
 =?us-ascii?Q?/v5OK9i17liRX7qwTP0GkXZLvoTOgiNZTwLjQZrqiYiwaz5devpV3f3TR/KL?=
 =?us-ascii?Q?iK89LmysU9zgsfSd/Nq+G4ascEth15hpMlN/gl06m2rsGIMA7h3mKu4rOkZt?=
 =?us-ascii?Q?ugYlb3SalxJbB1/Ur+THWt286ncMj7pwud5hyMhrTKoK+qiL3J0mA65PchZg?=
 =?us-ascii?Q?qxdtQCpVMZTjYAO3q3Hi1Gl07YCBZOmJpAlCk37HukqU8yGENorDczeQJwlZ?=
 =?us-ascii?Q?0yeETws+AoDowBUgfU1Yjb8109Y2PVTgxlxxOKRc6+Fi/4atxmbR0muFT3zY?=
 =?us-ascii?Q?DxrOJkxowCSqchQrhHCBgEtlTFHaMWHaM2ypnO9V7k02LhglOg4dD5YGMXBS?=
 =?us-ascii?Q?nCq0rZxX3VdnXOmGsK2MAeEAeorAUPlybDiXiAAVGKX3XoBAz1/YM7EZxEww?=
 =?us-ascii?Q?Ab2Dg1rzVh17Kcp4zx2eLKu679P6i7O8E/F+ox4BQAiMjk5utlw468dacQkH?=
 =?us-ascii?Q?FX6r8ZRdxZS4Xl1qjwXhn4HigZ5b+Z5r+SFmELrmnrluH68g0ZtnnwS2kSDT?=
 =?us-ascii?Q?MSDbAFwi9/Jh2IYAo6EzoT9jp9RknnOhS2YMDMn0ApMR0JkKCTPt7XxEhkZz?=
 =?us-ascii?Q?r82apGQRPqP7qMvyT64deOZHtiak+NFA5lNgwt17OHpdlemLFVsge29YsrV3?=
 =?us-ascii?Q?uUr/bCs4nlz45m+tZi05G3tr5mnpx8O6Zg5CJpZ9z75aVkfedZR2D5sCMokn?=
 =?us-ascii?Q?7lmFxG6nsO+c8dJRI6TCQiETc2NblQER2NWAWPoxJraGTnzJxwLfGXBOIpOm?=
 =?us-ascii?Q?cYg9VobeBD8oAQ84v0Uk6QEY1JL3S5Lh3qjFIuntdCV/P6Sv6WNhyWelUUE5?=
 =?us-ascii?Q?Z8yUdpguJMKrDjZT9ThpjW42EddtMUzxqY177MC3ZmzkuwB5MEti4aoCbGKx?=
 =?us-ascii?Q?D1oayrQgSJwIAlDVvV5PR3vGdPxOMy4sTRn+W+h1JYpXbfWOy4ibyoIf1rmf?=
 =?us-ascii?Q?Wuq8/t4GUaNSQrweDw+cFeWZlii5r+KHlR2wYe7EVua0t6kEkqeAG7eRs51V?=
 =?us-ascii?Q?OSk5Fx7YngVkjTldHDU7wwvIAuP9sTG3bKDdq31zkoeN592Bedjn0dp0UC1H?=
 =?us-ascii?Q?9lcfwlde9Xd7MslGIREVCJBzisitiemXEgzjWR3PybdpWK19UI8b+3x2cZ/Y?=
 =?us-ascii?Q?pA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74964baa-9def-434a-9c0e-08dc766dcc23
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 12:35:12.9191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4bqAltkQ4SFLO5t7/Tsuifv2gu4HneD3XXTAQz/bErwSSq/iW9qp1xQfthYK7WMU2dc6F0kBw6xDm1lZIn6GLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8934

This updates bt_bap_verify_bis to handle NULL L2 and/or L3 caps.
---
 src/shared/bap.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 38c353a6d..40ce16d75 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -6531,6 +6531,20 @@ void bt_bap_verify_bis(struct bt_bap *bap, uint8_t bis_index,
 	struct bt_ltv_extract merge_data = {0};
 	struct bt_ltv_match match_data;
 
+	if (!l2_caps)
+		/* Codec_Specific_Configuration parameters shall
+		 * be present at Level 2.
+		 */
+		return;
+
+	if (!l3_caps) {
+		/* Codec_Specific_Configuration parameters may
+		 * be present at Level 3.
+		 */
+		merge_data.result = util_iov_dup(l2_caps, 1);
+		goto done;
+	}
+
 	merge_data.src = l3_caps;
 	merge_data.result = new0(struct iovec, 1);
 
@@ -6542,6 +6556,7 @@ void bt_bap_verify_bis(struct bt_bap *bap, uint8_t bis_index,
 			NULL,
 			bap_sink_check_level2_ltv, &merge_data);
 
+done:
 	/* Check each BIS Codec Specific Configuration LTVs against our Codec
 	 * Specific Capabilities and if the BIS matches create a PAC with it
 	 */
-- 
2.39.2