Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4834-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/3] test-bap: Keep streams queue in test_data
Date: Tue, 21 May 2024 13:55:13 +0300
Message-Id: <20240521105515.103972-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20240521105515.103972-1-iulia.tanasescu@nxp.com>
References: <20240521105515.103972-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bh8aKqXszhvbTTsXY6GgTtMr7T0IzLn8xQ/UyRZ3DHrsyb/1Mp265ZuNm3/1?=
 =?us-ascii?Q?F5GZ2Whet2R/KjhDhVRocbhFXSq7SAKEvXXNOp9JDE2fk3F6HB6bXWUvMgJu?=
 =?us-ascii?Q?64id3Vf0R7YgKdlADx7gJF8QN2rLJfW5n/518NNM3rs0h7OVw8+xkUyLJyOY?=
 =?us-ascii?Q?OYXLNj8zAX23aRAdGh9vOCAD7yLDXLlO0tZhmgtbjYgFp+3QjYsysA61g5D7?=
 =?us-ascii?Q?5/VTS3fmo8IupzpjjK2xFXLDqH7p9DPFMd6YJsHjzSGw/WNMvXx28dQJX31Q?=
 =?us-ascii?Q?EwMYKQPxCk8nj8F4CeTYdw25SvCviuvE63UKW5EDEKZa1m/S2hMfzwyoS5cG?=
 =?us-ascii?Q?hd2riWBPuWZ1d2gvapuIxcBs5KXvFfgGVfuGJUY3qaLRCdPjbA1uBEv/XtcX?=
 =?us-ascii?Q?KLYWlhn0U0MlitnrR1YvkIlvmKZ2+fcH5BIsQy+NmDzpVCthjbCdbkoxLE+5?=
 =?us-ascii?Q?zz5rApR/tWqCUcMiu5BvcyBYIP8synvln0oy6QHtoj2fiJ/QRncoNK0Guy9n?=
 =?us-ascii?Q?CnhUBWmjzi3Nj3W5f4iy1IALixfjH1tyCFCg5G474mMF5IrGMTLFcA7y6W9G?=
 =?us-ascii?Q?qyOMr6k0078Hqzv4JLZ0cPYUrAdwBJ8w2/ZxOUPGwQMCdMitRgy0NmRZIj86?=
 =?us-ascii?Q?LvdsP83xOoX2jm90fFDgV5/EVhXmbSfqiMHqfvX3Bw+A/jR4w5mCv5AtfxuK?=
 =?us-ascii?Q?8CR1W9ch3cg6cGPKdQTb/BCAjHhY6bcb46jJptJWfuXrIbycPEp4WDqVCXtX?=
 =?us-ascii?Q?LjTpnsJVjOLD2T9n5ScUfGAj4if2L1R77C37lXo300K/atSEJJ7CYJ+P3fmC?=
 =?us-ascii?Q?xEUxjViBwSZDRgntcCwes7frVU/yVoMdKWx07oe2ZgLDc4ebngyXDGm8w6sO?=
 =?us-ascii?Q?VuIoUF39+vfNRqKyJj+Oa3HZ8Rlr+Z+BBRJ9DRI1zNt9QYcBJUANpN7lLFHz?=
 =?us-ascii?Q?eWGdWiyY1IHPg9nTozaKzg3YmIZZcEEgshQlLbFoynBSfRC3vUMNSZYN7acc?=
 =?us-ascii?Q?LaijlR9QyORMR3A6gU/PIXbV0kayz4r/BKyAuObm96+OLz/8sCenMdt39a/n?=
 =?us-ascii?Q?phVY/ahavUvqnCqXnjvj01PAjPJEyh+y4ZTY1PskyD62gQowtZwNcwdWVKVw?=
 =?us-ascii?Q?M7+katr5Rp9LzayqGjjjBOYg8lZ/xwKe0OJ42fF6o8KcjO4cST1i2APuZ5/0?=
 =?us-ascii?Q?3B9I+rU+aaJ6Z7uTd8/2kqTC+s3271uToUQYOHziv0qoNKopAQ4G2Sgkgd8C?=
 =?us-ascii?Q?AD5tT2h3om64Y/0oerEkj8t63QuOBlOKmifYTTWuzGTCwNZ1AxMOBPRD9ePy?=
 =?us-ascii?Q?+unSahGyaZq3XVTkyT1UgBacH1rEENcpoVBGS1c4DBgWrgN4kpvKBP1Hv+9T?=
 =?us-ascii?Q?6k+gRM57n2BrALrl3gdQsa75L0bfwjmugHqEziAr3IPyhjjTDiL7Ssmaw+o+?=
 =?us-ascii?Q?pzElaCB6nfD+VSqCQWxELKorLYaYEp1ebeJ6Az8rH8FVA0Kg+j4bPwci+Mtm?=
 =?us-ascii?Q?/ipSWaYVRB8nWXHw1O/JFx2CpI9kM13sEcfvBmDWqTbqBiISEUmX6h1go2i3?=
 =?us-ascii?Q?6AU4iYOaewGip4gsGzbtSCx4zsZIYNcUXb3zvSAsEw0H4HLpbAjAXov/gxs9?=
 =?us-ascii?Q?/Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9263eb4-19df-495b-701d-08dc7984902e
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 10:55:44.2311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RYkO+Pvi30mXPEp3TvODpzFbkQ7ZhhXJgIq9OBmCwblKgeOQflWqP5jGVK0StzsjwFlvWxUmRW5ToaSC7nkqzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10947

Some BAP test configurations require multiple streams to be created
(for example, 4.14.4 Broadcast Sink Receives Audio Data Over Multiple
BISes).

This replaces the stream pointer inside test_data with a queue of
streams, where each created stream is pushed.

Unicast callbacks where the created stream needs to be accessed
already pass the stream reference as parameter, so there is no need
to access it from test_data.
---
 unit/test-bap.c | 56 ++++++++++++++++++++++++++++++-------------------
 1 file changed, 34 insertions(+), 22 deletions(-)

diff --git a/unit/test-bap.c b/unit/test-bap.c
index 20609694e..061c7a119 100644
--- a/unit/test-bap.c
+++ b/unit/test-bap.c
@@ -56,7 +56,7 @@ struct test_data {
 	struct iovec *base;
 	struct iovec *caps;
 	struct test_config *cfg;
-	struct bt_bap_stream *stream;
+	struct queue *streams;
 	size_t iovcnt;
 	struct iovec *iov;
 };
@@ -80,6 +80,7 @@ static struct iovec lc3_caps = LC3_CAPABILITIES(LC3_FREQ_ANY, LC3_DURATION_ANY,
 		data.cfg = _cfg;				\
 		data.iovcnt = ARRAY_SIZE(iov_data(args));	\
 		data.iov = util_iov_dup(iov, ARRAY_SIZE(iov_data(args))); \
+		data.streams = queue_new(); \
 		tester_add(name, &data, setup, function,	\
 				test_teardown);			\
 	} while (0)
@@ -373,13 +374,13 @@ static void bap_enable(struct bt_bap_stream *stream,
 	case BT_BAP_STREAM_STATE_ENABLING:
 		return;
 	case BT_BAP_STREAM_STATE_DISABLING:
-		id = bt_bap_stream_disable(data->stream, true, bap_disable,
+		id = bt_bap_stream_disable(stream, true, bap_disable,
 						data);
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
 		if (data->cfg->snk)
 			return;
-		id = bt_bap_stream_start(data->stream, bap_start, data);
+		id = bt_bap_stream_start(stream, bap_start, data);
 		break;
 	}
 
@@ -400,7 +401,7 @@ static void bap_qos(struct bt_bap_stream *stream,
 	if (data->cfg->state > BT_BAP_STREAM_STATE_QOS) {
 		unsigned int qos_id;
 
-		qos_id = bt_bap_stream_enable(data->stream, true, NULL,
+		qos_id = bt_bap_stream_enable(stream, true, NULL,
 							bap_enable, data);
 		g_assert(qos_id);
 	}
@@ -420,7 +421,7 @@ static void bap_config(struct bt_bap_stream *stream,
 	if (data->cfg->state > BT_BAP_STREAM_STATE_CONFIG) {
 		unsigned int qos_id;
 
-		qos_id = bt_bap_stream_qos(data->stream, &data->cfg->qos,
+		qos_id = bt_bap_stream_qos(stream, &data->cfg->qos,
 					   bap_qos, data);
 		g_assert(qos_id);
 	}
@@ -431,13 +432,16 @@ static bool pac_found(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac,
 {
 	struct test_data *data = user_data;
 	unsigned int config_id;
+	struct bt_bap_stream *stream;
 
-	data->stream = bt_bap_stream_new(data->bap, lpac, rpac,
+	stream = bt_bap_stream_new(data->bap, lpac, rpac,
 						&data->cfg->qos,
 						&data->cfg->cc);
-	g_assert(data->stream);
+	g_assert(stream);
 
-	config_id = bt_bap_stream_config(data->stream, &data->cfg->qos,
+	queue_push_tail(data->streams, stream);
+
+	config_id = bt_bap_stream_config(stream, &data->cfg->qos,
 					&data->cfg->cc, bap_config, data);
 	g_assert(config_id);
 
@@ -529,15 +533,18 @@ static struct bt_bap_pac_ops bcast_pac_ops = {
 static void bsrc_pac_added(struct bt_bap_pac *pac, void *user_data)
 {
 	struct test_data *data = user_data;
+	struct bt_bap_stream *stream;
 
 	bt_bap_pac_set_ops(pac, &bcast_pac_ops, NULL);
 
-	data->stream = bt_bap_stream_new(data->bap, pac, NULL,
+	stream = bt_bap_stream_new(data->bap, pac, NULL,
 						&data->cfg->qos,
 						&data->cfg->cc);
-	g_assert(data->stream);
+	g_assert(stream);
 
-	bt_bap_stream_config(data->stream, &data->cfg->qos,
+	queue_push_tail(data->streams, stream);
+
+	bt_bap_stream_config(stream, &data->cfg->qos,
 					&data->cfg->cc, NULL, data);
 }
 
@@ -572,6 +579,7 @@ static void bsnk_pac_added(struct bt_bap_pac *pac, void *user_data)
 	struct bt_bap_pac *lpac;
 	struct iovec *cc;
 	struct bt_bap_codec codec = {0};
+	struct bt_bap_stream *stream;
 
 	if (data->cfg->vs)
 		codec.id = 0xff;
@@ -587,12 +595,14 @@ static void bsnk_pac_added(struct bt_bap_pac *pac, void *user_data)
 
 	bt_bap_pac_set_ops(pac, &bcast_pac_ops, NULL);
 
-	data->stream = bt_bap_stream_new(data->bap,
+	stream = bt_bap_stream_new(data->bap,
 		pac, NULL, &data->cfg->qos, cc);
 
-	g_assert(data->stream);
+	g_assert(stream);
 
-	bt_bap_stream_config(data->stream, &data->cfg->qos,
+	queue_push_tail(data->streams, stream);
+
+	bt_bap_stream_config(stream, &data->cfg->qos,
 			cc, NULL, NULL);
 
 	util_iov_free(cc, 1);
@@ -704,6 +714,8 @@ static void test_teardown(const void *user_data)
 	bt_bap_remove_pac(data->bsnk);
 	gatt_db_unref(data->db);
 
+	queue_destroy(data->streams, NULL);
+
 	tester_teardown_complete();
 }
 
@@ -2643,7 +2655,7 @@ static void state_start_disable(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_STREAMING:
-		id = bt_bap_stream_disable(data->stream, true, bap_disable,
+		id = bt_bap_stream_disable(stream, true, bap_disable,
 						data);
 		g_assert(id);
 		break;
@@ -2719,7 +2731,7 @@ static void state_cc_release(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_CONFIG:
-		id = bt_bap_stream_release(data->stream, bap_release, data);
+		id = bt_bap_stream_release(stream, bap_release, data);
 		g_assert(id);
 		break;
 	}
@@ -2788,7 +2800,7 @@ static void state_qos_release(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_QOS:
-		id = bt_bap_stream_release(data->stream, bap_release, data);
+		id = bt_bap_stream_release(stream, bap_release, data);
 		g_assert(id);
 		break;
 	}
@@ -2827,7 +2839,7 @@ static void state_enable_release(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_ENABLING:
-		id = bt_bap_stream_release(data->stream, bap_release, data);
+		id = bt_bap_stream_release(stream, bap_release, data);
 		g_assert(id);
 		break;
 	}
@@ -2866,7 +2878,7 @@ static void state_start_release(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_STREAMING:
-		id = bt_bap_stream_release(data->stream, bap_release, data);
+		id = bt_bap_stream_release(stream, bap_release, data);
 		g_assert(id);
 		break;
 	}
@@ -2894,7 +2906,7 @@ static void state_disable_release(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_DISABLING:
-		id = bt_bap_stream_release(data->stream, bap_release, data);
+		id = bt_bap_stream_release(stream, bap_release, data);
 		g_assert(id);
 		break;
 	}
@@ -2971,7 +2983,7 @@ static void state_enable_metadata(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_ENABLING:
-		id = bt_bap_stream_metadata(data->stream, &iov, bap_metadata,
+		id = bt_bap_stream_metadata(stream, &iov, bap_metadata,
 						data);
 		g_assert(id);
 		break;
@@ -3047,7 +3059,7 @@ static void state_start_metadata(struct bt_bap_stream *stream,
 
 	switch (new_state) {
 	case BT_BAP_STREAM_STATE_STREAMING:
-		id = bt_bap_stream_metadata(data->stream, &iov, bap_metadata,
+		id = bt_bap_stream_metadata(stream, &iov, bap_metadata,
 						data);
 		g_assert(id);
 		break;
-- 
2.39.2