Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Yo-Jung (Leo) Lin" <leo.lin@canonical.com>
To: luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org,
	kai.heng.feng@canonical.com,
	0xff07@gmail.com,
	Yo-Jung Lin <leo.lin@canonical.com>
Subject: Re: [PATCH v3] Bluetooth: L2CAP: Fix rejecting L2CAP_CONN_PARAM_UPDATE_REQ
Date: Thu, 23 May 2024 14:45:08 +0800
Message-Id: <20240523064508.6293-1-leo.lin@canonical.com>
In-Reply-To: <20240521143521.1568672-1-luiz.dentz@gmail.com>
References: <20240521143521.1568672-1-luiz.dentz@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

I tested it using the bluetooth-next, with HEAD at 
a3975db95fcd8e304f1ee4b0be1895038942a8ef. It rejects the connection
parameter update request at least for the case where the min > max,
which is one of the failed conditions for the hci_check_conn_params()

Note that TSPX_iut_invalid_connection_interval_{min, max} in the IXIT
can be used to create faulty connection parameters.

The specific test steps are:

1. Set TSPX_iut_invalid_connection_interval_min to a value larger
   than TSPX_iut_invalid_connection_interval_max, e.g. 0xAB and 0xAA
   respectively.

2. Start the GAP/CONN/CPUP/BV-05-C case on PTS.

3. Enter bluetoothctl. Use "scan on" to find the address of PTS dongle.

4. Meanwhile, PTS will ask for connect request. Connect to it by
   running "connect $PTS_ADDR" in bluetoothctl.

5. At this point the PTS would send the parameter update request with
   faulty parameters set in the IXIT. Kernel will reject this request.

6. PST will then ask to send a disconnect request. Run "disconnect"
   in bluetoothctl. The test case should pass after disconnection.

Tested-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>