Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-5026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240529033038.28458-1-chris.lu@mediatek.com>
In-Reply-To: <20240529033038.28458-1-chris.lu@mediatek.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 29 May 2024 11:21:05 -0400
Message-ID: <CABBYNZLEWCFo_OWvPxaM54S65-mAhZ-3R1XgRqb-UnUChcJV9w@mail.gmail.com>
Subject: Re: [PATCH 0/3] Bluetooth: btusb: MediaTek ISO data transmission support
To: Chris Lu <chris.lu@mediatek.com>
Cc: Marcel Holtmann <marcel@holtmann.org>, Johan Hedberg <johan.hedberg@gmail.com>, 
	Sean Wang <sean.wang@mediatek.com>, Deren Wu <deren.Wu@mediatek.com>, 
	Aaron Hou <aaron.hou@mediatek.com>, Steve Lee <steve.lee@mediatek.com>, 
	linux-bluetooth <linux-bluetooth@vger.kernel.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>, 
	linux-mediatek <linux-mediatek@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, May 28, 2024 at 11:30=E2=80=AFPM Chris Lu <chris.lu@mediatek.com> w=
rote:
>
> Since SIG hasn't clearly defined the specification about ISO data over US=
B
> transmission yet, MediaTek adopts a method by adding an additional interr=
upt
> endpoint for ISO data transmission which is different from current way
> on Bluetooth upstream driver using existed bulk. Interrupt endpoint has
> guaranteed bandwidth, sufficient max data length for LE audio packet and
> support error checking. These characteristics are similar to the use of I=
SO data.
>
> Chris Lu (3):
>   Bluetooth: net: add hci_iso_hdr function for iso data
>   Bluetooth: btmtk: add macro to get/set/clear MediaTek defined flags
>   Bluetooth: btusb: mediatek: add MediaTek ISO data transmission
>     function
>
>  drivers/bluetooth/btmtk.c   |  35 +++++
>  drivers/bluetooth/btmtk.h   |  46 ++++++
>  drivers/bluetooth/btusb.c   | 293 +++++++++++++++++++++++++++++++++++-
>  include/net/bluetooth/hci.h |   5 +
>  4 files changed, 378 insertions(+), 1 deletion(-)

This probably needs to be handled in btmtk.c though, since it is not
standard we shall avoid having vendor specific transports like this in
btusb.c


--=20
Luiz Augusto von Dentz