Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240607121522.1255175-1-yauhen.kharuzhy@softeq.com>
In-Reply-To: <20240607121522.1255175-1-yauhen.kharuzhy@softeq.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Fri, 7 Jun 2024 10:03:35 -0400
Message-ID: <CABBYNZ+czz7S9Dk0mRC4D+uU+Y8V6BZXnZWpvS9eN_GPbDhsmg@mail.gmail.com>
Subject: Re: [PATCH BlueZ] mcp: Implement Next Track and Previous Track commands
To: Yauhen Kharuzhy <yauhen.kharuzhy@softeq.com>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Yauhen,

On Fri, Jun 7, 2024 at 8:15=E2=80=AFAM Yauhen Kharuzhy
<yauhen.kharuzhy@softeq.com> wrote:
>
> Add implementation of Next/Previous Track commands to audio/mcp profile
> and shared/mcp.{c,h} code.
> ---
>  profiles/audio/mcp.c | 18 ++++++++++++++++--
>  src/shared/mcp.c     | 20 ++++++++++++++++++++
>  src/shared/mcp.h     |  2 ++

Please have the changes to src/shared split from other changes, they
have different licenses and shared may actually be subject to unit
testing.

>  3 files changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/profiles/audio/mcp.c b/profiles/audio/mcp.c
> index b410b3d2a..8d1b7588e 100644
> --- a/profiles/audio/mcp.c
> +++ b/profiles/audio/mcp.c
> @@ -224,13 +224,27 @@ static int ct_stop(struct media_player *mp, void *u=
ser_data)
>         return bt_mcp_stop(mcp);
>  }
>
> +static int ct_next(struct media_player *mp, void *user_data)
> +{
> +       struct bt_mcp *mcp =3D user_data;
> +
> +       return bt_mcp_next_track(mcp);
> +}
> +
> +static int ct_previous(struct media_player *mp, void *user_data)
> +{
> +       struct bt_mcp *mcp =3D user_data;
> +
> +       return bt_mcp_previous_track(mcp);
> +}
> +
>  static const struct media_player_callback ct_cbs =3D {
>         .set_setting    =3D NULL,
>         .play           =3D &ct_play,
>         .pause          =3D &ct_pause,
>         .stop           =3D &ct_stop,
> -       .next           =3D NULL,
> -       .previous       =3D NULL,
> +       .next           =3D &ct_next,
> +       .previous       =3D &ct_previous,
>         .fast_forward   =3D NULL,
>         .rewind         =3D NULL,
>         .press          =3D NULL,
> diff --git a/src/shared/mcp.c b/src/shared/mcp.c
> index b3726ebae..71fc2d151 100644
> --- a/src/shared/mcp.c
> +++ b/src/shared/mcp.c
> @@ -628,6 +628,26 @@ unsigned int bt_mcp_stop(struct bt_mcp *mcp)
>         return mcp_send(mcp, BT_MCS_CMD_STOP);
>  }
>
> +unsigned int bt_mcp_next_track(struct bt_mcp *mcp)
> +{
> +       if (!(mcp->session.cp_op_supported & BT_MCS_CMD_NEXT_TRACK_SUPPOR=
TED))
> +               return -ENOTSUP;
> +
> +       DBG(mcp, "mcp %p", mcp);
> +
> +       return mcp_send(mcp, BT_MCS_CMD_NEXT_TRACK);
> +}
> +
> +unsigned int bt_mcp_previous_track(struct bt_mcp *mcp)
> +{
> +       if (!(mcp->session.cp_op_supported & BT_MCS_CMD_PREV_TRACK_SUPPOR=
TED))
> +               return -ENOTSUP;
> +
> +       DBG(mcp, "mcp %p", mcp);
> +
> +       return mcp_send(mcp, BT_MCS_CMD_PREV_TRACK);
> +}
> +
>  static void mcp_mp_set_player_name(struct bt_mcp *mcp, const uint8_t *va=
lue,
>                                         uint16_t length)
>  {
> diff --git a/src/shared/mcp.h b/src/shared/mcp.h
> index a2cd6fc45..ee57ed4bf 100644
> --- a/src/shared/mcp.h
> +++ b/src/shared/mcp.h
> @@ -59,3 +59,5 @@ void *bt_mcp_get_user_data(struct bt_mcp *mcp);
>  unsigned int bt_mcp_play(struct bt_mcp *mcp);
>  unsigned int bt_mcp_pause(struct bt_mcp *mcp);
>  unsigned int bt_mcp_stop(struct bt_mcp *mcp);
> +unsigned int bt_mcp_next_track(struct bt_mcp *mcp);
> +unsigned int bt_mcp_previous_track(struct bt_mcp *mcp);
> --
> 2.45.1
>
>


--=20
Luiz Augusto von Dentz