2008-09-29 15:05:16

by Mario Limonciello

[permalink] [raw]
Subject: RE: [PATCH] Make bluetooth-properties fit on smaller displays

Hi Bastien & Marcel:

Here's the screenshots as requested:

Old: http://imagebin.org/27644

New: http://imagebin.org/27643

A lot of these MID devices don't have screens bigger than 1024x600 (some 800x600 depending on their aspect ratio). This change really just reorganizes the GUI so that both laptops and MID devices can use the same layout. I'm attaching an updated patch relative to 1.6.

Regards

Mario Limonciello
Dell | Linux Engineering
[email protected]



-----Original Message-----
From: [email protected] on behalf of Bastien Nocera
Sent: Mon 9/29/2008 4:15 AM
To: Marcel Holtmann
Cc: Limonciello, Mario; [email protected]
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays

On Mon, 2008-09-29 at 11:07 +0200, Marcel Holtmann wrote:
> Hi Mario,
>
> > Ubuntu was carrying a "hildon" patch to make the bluetooth-properties application fit on smaller form factors for lpia. We've adapted the patch to be applicable to all platforms. It changes the layout of the bluetooth-properties window to be better for small displays without a loss of functionality.
>
> I have no idea what this patch tries to achieve. How will this save
> space on small displays?

A before/after screenshot would be useful indeed. If it's a good layout,
it should probably be used by default.


Attachments:
06_preferences-horizontal-layout.patch (3.36 kB)
06_preferences-horizontal-layout.patch

2008-09-30 08:56:51

by David Sainty

[permalink] [raw]
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays

Marcel Holtmann wrote:
> Hi David,
>
>
>>>> A lot of these MID devices don't have screens bigger than 1024x600
>>>> (some 800x600 depending on their aspect ratio). This change really
>>>> just reorganizes the GUI so that both laptops and MID devices can use
>>>> the same layout. I'm attaching an updated patch relative to 1.6.
>>>>
>>>>
>>> Both versions would fit on both those screens. What's wrong with leaving
>>> it as is? In the worst case, I'd move the contextual buttons to the side
>>> of the treeview, instead of underneath, and add labels to those buttons.
>>>
>>>
>> The preferences dialog on an Eee PC (701) screen is a real pain, it is
>> too big vertically. 800x480 screen, plus a window manager bar at the
>> bottom, plus some chunky window decorations up the top. For a window to
>> fit conveniently on a standard Eee PC screen it needs to be 422 pixels
>> vertically it looks like (the standard decorations are VERY chunky :)
>>
>
> the dialog ix 420x420 and thus it should fit.
>
Interesting - that's not what I'm seeing. I've just tried xwininfo on
bluez-gnome-1.7 on both an Eee PC and a full sized PC (possibly with
slightly different support library versions).

Full sized PC geometry for the preferences window is 420x521. EeePC
geometry for the same is 420x523.
I'm not sure where the 2 pixel difference comes from (I don't think
the geometry here is including the window manager decorations). But
neither are close to 420x420. You weren't thinking 420x520 perchance?

2008-09-30 08:17:29

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays

Hi David,

> >> A lot of these MID devices don't have screens bigger than 1024x600
> >> (some 800x600 depending on their aspect ratio). This change really
> >> just reorganizes the GUI so that both laptops and MID devices can use
> >> the same layout. I'm attaching an updated patch relative to 1.6.
> >>
> >
> > Both versions would fit on both those screens. What's wrong with leaving
> > it as is? In the worst case, I'd move the contextual buttons to the side
> > of the treeview, instead of underneath, and add labels to those buttons.
> >
> The preferences dialog on an Eee PC (701) screen is a real pain, it is
> too big vertically. 800x480 screen, plus a window manager bar at the
> bottom, plus some chunky window decorations up the top. For a window to
> fit conveniently on a standard Eee PC screen it needs to be 422 pixels
> vertically it looks like (the standard decorations are VERY chunky :)

the dialog ix 420x420 and thus it should fit.

Regards

Marcel



2008-09-30 08:00:40

by David Sainty

[permalink] [raw]
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays

Bastien Nocera wrote:
> On Mon, 2008-09-29 at 10:05 -0500, [email protected] wrote:
>
>> Hi Bastien & Marcel:
>>
>> Here's the screenshots as requested:
>>
>> Old: http://imagebin.org/27644
>>
>> New: http://imagebin.org/27643
>>
>> A lot of these MID devices don't have screens bigger than 1024x600
>> (some 800x600 depending on their aspect ratio). This change really
>> just reorganizes the GUI so that both laptops and MID devices can use
>> the same layout. I'm attaching an updated patch relative to 1.6.
>>
>
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.
>
The preferences dialog on an Eee PC (701) screen is a real pain, it is
too big vertically. 800x480 screen, plus a window manager bar at the
bottom, plus some chunky window decorations up the top. For a window to
fit conveniently on a standard Eee PC screen it needs to be 422 pixels
vertically it looks like (the standard decorations are VERY chunky :)

2008-09-29 23:41:33

by Marcel Holtmann

[permalink] [raw]
Subject: RE: [PATCH] Make bluetooth-properties fit on smaller displays

Hi Bastien,

> > Here's the screenshots as requested:
> >
> > Old: http://imagebin.org/27644
> >
> > New: http://imagebin.org/27643
> >
> > A lot of these MID devices don't have screens bigger than 1024x600
> > (some 800x600 depending on their aspect ratio). This change really
> > just reorganizes the GUI so that both laptops and MID devices can use
> > the same layout. I'm attaching an updated patch relative to 1.6.
>
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.

I really don't see the advantage of the vertical layout. For the buttons
I tried to use a ToolBar, but that looks ugly since I can get rid of the
top and bottom frame. Otherwise we could have put that to the right of
the TreeView and saved the extra space you guys need.

Regards

Marcel




2008-09-29 16:47:12

by Emmet Hikory

[permalink] [raw]
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays

On Tue, Sep 30, 2008 at 12:22 AM, Bastien Nocera <[email protected]> wrote:
> On Mon, 2008-09-29 at 10:05 -0500, [email protected] wrote:
>> Hi Bastien & Marcel:
>>
>> Here's the screenshots as requested:
>>
>> Old: http://imagebin.org/27644
>>
>> New: http://imagebin.org/27643
>>
>> A lot of these MID devices don't have screens bigger than 1024x600
>> (some 800x600 depending on their aspect ratio). This change really
>> just reorganizes the GUI so that both laptops and MID devices can use
>> the same layout. I'm attaching an updated patch relative to 1.6.
>
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.

Good day. I adapted the suggested patch for this from one
previously shipped in Ubuntu by Michael Frey and Loic Minier.

My actual test screens were 1024x600 (intel driver) and 800x600
(vesa driver), running under the hildon-desktop environment. If I'm
running in clean [email protected], the default looks OK, but there is only
space for two or three devices. If I'm running under hildon-desktop,
there's only space for one device. As one of these screens is
actually 247 DPI, running at 96 DPI tends to make everything nearly
unreadably small. Note that I've also tested with GNOME+devilspie, to
force maximisation, which created a bit more space, but not hugely
more space.

In practice, I use a keyboard, headset, communication to a yet
smaller portable device, and communication to my laptop. I'd like to
add a mouse, GPS device, and printer. I'm experimenting with a
"bluetooth handset" for making VoIP calls, which would be a separate
audio device for ekiga/empathy. As a result, my device listing easily
exceeds the limits imposed by the vertical layout on a small screen.
Whlie this may be an exceptional case, I think "mouse, keyboard,
headset, phone, printer" isn't an unreasonable list of accessories,
even for a regular laptop user.

One possible solution would be to write a separate hildon front
end, which is probably the best solution for 640x480 or 800x480, but
for 800x600 and 1024x600, the use case for using themed GNOME with
higher DPI hinting is strong enough that having a separate front-end
seems confusing.

Mind you, I don't want to limit the experience on high-resolution
low-DPI screens, and will admit that I don't have the equipment to
properly test this use case. If the consensus is that it the result
of moving the device listing to the right creates an unpleasant
experience for these users, then perhaps it is not a sensible default.

--
Emmet HIKORY

2008-09-29 15:22:10

by Bastien Nocera

[permalink] [raw]
Subject: RE: [PATCH] Make bluetooth-properties fit on smaller displays

On Mon, 2008-09-29 at 10:05 -0500, [email protected] wrote:
> Hi Bastien & Marcel:
>
> Here's the screenshots as requested:
>
> Old: http://imagebin.org/27644
>
> New: http://imagebin.org/27643
>
> A lot of these MID devices don't have screens bigger than 1024x600
> (some 800x600 depending on their aspect ratio). This change really
> just reorganizes the GUI so that both laptops and MID devices can use
> the same layout. I'm attaching an updated patch relative to 1.6.

Both versions would fit on both those screens. What's wrong with leaving
it as is? In the worst case, I'd move the contextual buttons to the side
of the treeview, instead of underneath, and add labels to those buttons.