2008-11-25 13:14:54

by Julia Lawall

[permalink] [raw]
Subject: [PATCH 4/5] drivers/bluetooth: change simple_strtol to simple_strtoul

From: Julia Lawall <[email protected]>

Since size, addr, fcs, and tmp are unsigned, it would seem better to use
simple_strtoul that simple_strtol.

A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@[email protected]
long e;
position p;
@@

e = [email protected](...)

@@
position p != r2.p;
type T;
T e;
@@

e =
- [email protected]
+ simple_strtoul
(...)
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---

drivers/bluetooth/bt3c_cs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff -u -p a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
--- a/drivers/bluetooth/bt3c_cs.c
+++ b/drivers/bluetooth/bt3c_cs.c
@@ -502,15 +502,15 @@ static int bt3c_load_firmware(bt3c_info_

memset(b, 0, sizeof(b));
memcpy(b, ptr + 2, 2);
- size = simple_strtol(b, NULL, 16);
+ size = simple_strtoul(b, NULL, 16);

memset(b, 0, sizeof(b));
memcpy(b, ptr + 4, 8);
- addr = simple_strtol(b, NULL, 16);
+ addr = simple_strtoul(b, NULL, 16);

memset(b, 0, sizeof(b));
memcpy(b, ptr + (size * 2) + 2, 2);
- fcs = simple_strtol(b, NULL, 16);
+ fcs = simple_strtoul(b, NULL, 16);

memset(b, 0, sizeof(b));
for (tmp = 0, i = 0; i < size; i++) {
@@ -530,7 +530,7 @@ static int bt3c_load_firmware(bt3c_info_
memset(b, 0, sizeof(b));
for (i = 0; i < (size - 4) / 2; i++) {
memcpy(b, ptr + (i * 4) + 12, 4);
- tmp = simple_strtol(b, NULL, 16);
+ tmp = simple_strtoul(b, NULL, 16);
bt3c_put(iobase, tmp);
}
}


2008-11-30 08:53:13

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 4/5] drivers/bluetooth: change simple_strtol to simple_strtoul

Hi Julia,

> From: Julia Lawall <[email protected]>
>
> Since size, addr, fcs, and tmp are unsigned, it would seem better to use
> simple_strtoul that simple_strtol.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://www.emn.fr/x-info/coccinelle/)

patch has been applied to my tree. Thanks.

Regards

Marcel