2009-01-08 18:44:35

by Mike Lockwood

Subject: [PATCH] Fix a bogus pointer crash that occurred when reconnecting A2DP.

commit af5d46b22852f4ec1ca0d7c43c7a7e71292fe334
Author: Mike Lockwood <[email protected]>
Date: Thu Jan 8 13:34:06 2009 -0500

Fix a bogus pointer crash that occurred when reconnecting A2DP.

Signed-off-by: Mike Lockwood <[email protected]>

diff --git a/audio/unix.c b/audio/unix.c
index 1e4dd2d..ad31181 100644
--- a/audio/unix.c
+++ b/audio/unix.c
@@ -919,6 +919,7 @@ static int handle_a2dp_transport(struct unix_client *client,
if (client->caps) {
g_slist_foreach(client->caps, (GFunc) g_free, NULL);
g_slist_free(client->caps);
+ client->caps = NULL;
}

media_transport = avdtp_service_cap_new(AVDTP_MEDIA_TRANSPORT,

2009-01-08 19:44:22

by Johan Hedberg

Subject: Re: [PATCH] Fix a bogus pointer crash that occurred when reconnecting A2DP.

Hi Mike,
On Jan 8, 2009, at 20:44, Mike Lockwood wrote:
> commit af5d46b22852f4ec1ca0d7c43c7a7e71292fe334
> Author: Mike Lockwood <[email protected]>
> Date: Thu Jan 8 13:34:06 2009 -0500
>
> Fix a bogus pointer crash that occurred when reconnecting A2DP.

The patch has now been applied and pushed upstream. Thanks!

In the future you might want to consider using an attachment for
patches since now something (most likely your email client) messed up
the tabs and converted them to spaces which made the patch not apply
properly. Also, we don't use the Signed-off-by stuff on the userspace
side of BlueZ so you can leave it out.

Johan