2009-03-24 11:55:09

by Bastien Nocera

[permalink] [raw]
Subject: [PATCH] Fix another sdp-xml bug

Spotted by Luiz, another invalid memory access when trying to read past
the end of a string that's not nul-terminated.

strndup to the rescue.

Cheers


Attachments:
0001-Fix-invalid-memory-access-when-dealing-with-URLs.patch (1.15 kB)

2009-03-24 12:23:54

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] Fix another sdp-xml bug

Hi,

On Tue, Mar 24, 2009, Bastien Nocera wrote:
> Never mind, previous patch was off by one. Corrected patch attached.

I already pushed the first one and fixed this issue myself in a second
commit.

Johan

2009-03-24 12:12:42

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] Fix another sdp-xml bug

Hi Bastien,

On Tue, Mar 24, 2009, Bastien Nocera wrote:
> Spotted by Luiz, another invalid memory access when trying to read past
> the end of a string that's not nul-terminated.
>
> strndup to the rescue.

Thanks! Pushed upstream.

Johan

2009-03-24 12:03:24

by Bastien Nocera

[permalink] [raw]
Subject: Re: [PATCH] Fix another sdp-xml bug

On Tue, 2009-03-24 at 11:55 +0000, Bastien Nocera wrote:
> Spotted by Luiz, another invalid memory access when trying to read past
> the end of a string that's not nul-terminated.
>
> strndup to the rescue.

Never mind, previous patch was off by one. Corrected patch attached.


Attachments:
0001-Fix-invalid-memory-access-when-dealing-with-URLs.patch (1.16 kB)