2021-03-24 19:01:25

by Yu Liu

Subject: [RFC PATCH v2] doc/mgmt-api - Return connection direction in Device Connected Event

When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.

Reviewed-by: Miao-chen Chou <[email protected]>
Reviewed-by: Alain Michaud <[email protected]>
Signed-off-by: Yu Liu <[email protected]>
---

Changes in v2:
- Use next free bit

Changes in v1:
- Initial change

doc/mgmt-api.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index cab1fffc5..98552e761 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4088,6 +4088,7 @@ Device Connected Event
0 Reserved (not in use)
1 Legacy Pairing
2 Reserved (not in use)
+ 3 Initiated Connection


Device Disconnected Event
--
2.31.0.291.g576ba9dcdaf-goog

2021-03-24 19:26:11

by bluez.test.bot

Subject: RE: [RFC,v2] doc/mgmt-api - Return connection direction in Device Connected Event

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=454837

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2021-03-26 07:43:25

by Marcel Holtmann

Subject: Re: [RFC PATCH v2] doc/mgmt-api - Return connection direction in Device Connected Event

Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
>
> Reviewed-by: Miao-chen Chou <[email protected]>
> Reviewed-by: Alain Michaud <[email protected]>
> Signed-off-by: Yu Liu <[email protected]>
> ---
>
> Changes in v2:
> - Use next free bit
>
> Changes in v1:
> - Initial change
>
> doc/mgmt-api.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index cab1fffc5..98552e761 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4088,6 +4088,7 @@ Device Connected Event
> 0 Reserved (not in use)
> 1 Legacy Pairing
> 2 Reserved (not in use)
> + 3 Initiated Connection

please also mark it reserved in Device Found event.

Regards

Marcel