2021-06-08 17:45:14

by Michael Sun

[permalink] [raw]
Subject: [BlueZ PATCH v1] avrcp: fix byte order of PDU parameter length compare

Fix the issue that directly uses params_len, from received PDU data,
for arithmetic calculation and comparison.

Reviewed-by: Alain Michaud <[email protected]>
Signed-off-by: Michael Sun <[email protected]>
---

profiles/audio/avrcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index ccf34b220..2265f87ab 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -1923,9 +1923,9 @@ static size_t handle_vendordep_pdu(struct avctp *conn, uint8_t transaction,
operands += sizeof(*pdu);
operand_count -= sizeof(*pdu);

- if (pdu->params_len != operand_count) {
+ if (pdu->params_len != htons(operand_count)) {
DBG("AVRCP PDU parameters length don't match");
- pdu->params_len = operand_count;
+ pdu->params_len = htons(operand_count);
}

for (handler = session->control_handlers; handler->pdu_id; handler++) {
--
2.32.0.rc1.229.g3e70b5a671-goog


2021-06-08 18:20:04

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1] avrcp: fix byte order of PDU parameter length compare

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=496449

---Test result---

Test Summary:
CheckPatch PASS 0.50 seconds
GitLint PASS 0.11 seconds
Prep - Setup ELL PASS 39.24 seconds
Build - Prep PASS 0.09 seconds
Build - Configure PASS 7.04 seconds
Build - Make PASS 167.01 seconds
Make Check PASS 8.71 seconds
Make Distcheck PASS 200.39 seconds
Build w/ext ELL - Configure PASS 6.98 seconds
Build w/ext ELL - Make PASS 159.92 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth