2021-07-22 02:23:02

by wangyouwan

[permalink] [raw]
Subject: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.92292 7

I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2

8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a slave when
joining an existing piconet, since by definition the paging device is initially
master of a piconet involving the pager (master) and the paged (slave)
device.
• A role switch is necessary in order for a slave in an existing piconet to set up
a new piconet with itself as master and the original piconet master as slave.
If the original piconet had more than one slave, then this implies a double
role for the original piconet master; it becomes a slave

Signed-off-by: wangyouwan <[email protected]>
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 52d22ab21..b73615509 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
str = "Stay master";
break;
case 0x01:
- str = "Allow slave";
+ str = "Master Or Slave";
break;
default:
str = "Reserved";
--
2.20.1




2021-07-22 07:11:39

by Barry Byford

[permalink] [raw]
Subject: Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927

On Thu, 22 Jul 2021 at 03:23, wangyouwan <[email protected]> wrote:
>
> I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
>

There is now Core V5.3 which has been updated to use inclusive
language as outlined by Archie in his post:

https://marc.info/?l=linux-bluetooth&m=162195325125419&w=2

I think the terms should be Central or Peripheral. Here is the same
extract from the spec in v5.3

8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a Peripheral
when joining an existing piconet, since by definition the paging device is
initially Central of a piconet involving the pager (Central) and the paged
(Peripheral) device.
• A role switch is necessary in order for a Peripheral in an existing piconet to
set up a new piconet with itself as Central and the original piconet Central as
Peripheral. If the original piconet had more than one Peripheral, then this
implies a double role for the original piconet Central; it becomes a Peripheral
in the new piconet while still maintaining the original piconet as Central.

> 8.6.5 Role switch
> There are several occasions when a role switch is used:
> • A role switch is necessary in order to make a paging device a slave when
> joining an existing piconet, since by definition the paging device is initially
> master of a piconet involving the pager (master) and the paged (slave)
> device.
> • A role switch is necessary in order for a slave in an existing piconet to set up
> a new piconet with itself as master and the original piconet master as slave.
> If the original piconet had more than one slave, then this implies a double
> role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <[email protected]>
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
> str = "Stay master";
> break;
> case 0x01:
> - str = "Allow slave";
> + str = "Master Or Slave";
> break;
> default:
> str = "Reserved";
> --
> 2.20.1
>
>
>

2021-07-22 14:49:18

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.92 2927

Hi Wang,

> I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
>
> 8.6.5 Role switch
> There are several occasions when a role switch is used:
> • A role switch is necessary in order to make a paging device a slave when
> joining an existing piconet, since by definition the paging device is initially
> master of a piconet involving the pager (master) and the paged (slave)
> device.
> • A role switch is necessary in order for a slave in an existing piconet to set up
> a new piconet with itself as master and the original piconet master as slave.
> If the original piconet had more than one slave, then this implies a double
> role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <[email protected]>
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
> str = "Stay master";
> break;
> case 0x01:
> - str = "Allow slave";
> + str = "Master Or Slave";
> break;

the text was verbatim from Bluetooth 4.x core spec. If that has changed in Core 5.3 spec, then we can use that one.

Regards

Marcel