2021-07-22 06:02:15

by Ayush Garg

Subject: [PATCH BlueZ 2/8] doc/mgmt-api: Add support for LE PHY Update Complete event

Reviewed-by: Anupam Roy <[email protected]>
---
doc/mgmt-api.txt | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index 5355fedb0..f7379fcd9 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4910,3 +4910,32 @@ Controller Resume Event
Address_Type. Otherwise, Address and Address_Type will both be zero.

This event will be sent to all management sockets.
+
+
+LE PHY Update Complete Event
+===============================
+
+ Event Code: 0x002f
+ Controller Index: <controller id>
+ Event Parameters: Address (6 Octets)
+ Address_Type (1 Octet)
+ Status (1 Octet)
+ PHYs (4 Octets)
+
+ This event indicates that LE PHYs have been changed for this
+ connected device.
+
+ The PHYs parameters are a bitmask with currently the
+ following available bits:
+
+ 9 LE 1M TX
+ 10 LE 1M RX
+ 11 LE 2M TX
+ 12 LE 2M RX
+ 13 LE Coded TX
+ 14 LE Coded RX
+
+ This event will be used in case of autonomous PHY update made
+ by the controller or HCI_LE_SET_PHY command succeeded.
+
+ This event will be sent to all management sockets.
--
2.17.1

2021-07-22 14:45:50

by Marcel Holtmann

Subject: Re: [PATCH BlueZ 2/8] doc/mgmt-api: Add support for LE PHY Update Complete event

Hi Ayush,

> Reviewed-by: Anupam Roy <[email protected]>
> ---
> doc/mgmt-api.txt | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 5355fedb0..f7379fcd9 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4910,3 +4910,32 @@ Controller Resume Event
> Address_Type. Otherwise, Address and Address_Type will both be zero.
>
> This event will be sent to all management sockets.
> +
> +
> +LE PHY Update Complete Event
> +===============================
> +
> + Event Code: 0x002f
> + Controller Index: <controller id>
> + Event Parameters: Address (6 Octets)
> + Address_Type (1 Octet)
> + Status (1 Octet)
> + PHYs (4 Octets)
> +
> + This event indicates that LE PHYs have been changed for this
> + connected device.
> +
> + The PHYs parameters are a bitmask with currently the
> + following available bits:
> +
> + 9 LE 1M TX
> + 10 LE 1M RX
> + 11 LE 2M TX
> + 12 LE 2M RX
> + 13 LE Coded TX
> + 14 LE Coded RX
> +
> + This event will be used in case of autonomous PHY update made
> + by the controller or HCI_LE_SET_PHY command succeeded.
> +
> + This event will be sent to all management sockets.

As mentioned in the code review, I don’t like doing it this way.

Regards

Marcel