by bluez.test.bot

[permalink] [raw]

Subject: RE: Kernel based mesh functionality

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=617384

---Test result---

Test Summary:
CheckPatch FAIL 4.85 seconds
GitLint PASS 2.61 seconds
Prep - Setup ELL PASS 48.28 seconds
Build - Prep PASS 0.44 seconds
Build - Configure PASS 9.45 seconds
Build - Make PASS 1347.83 seconds
Make Check PASS 12.25 seconds
Make Check w/Valgrind PASS 465.19 seconds
Make Distcheck PASS 243.36 seconds
Build w/ext ELL - Configure PASS 8.66 seconds
Build w/ext ELL - Make PASS 1383.39 seconds
Incremental Build with patchesFAIL 4627.24 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[1/7] mgmt: Add support for Mesh in the kernel
WARNING:REPEATED_WORD: Possible repeated word: 'command'
#252: FILE: doc/mgmt-api.txt:5143:
+ the Set Mesh Receiver command command, specifying which AD Types to

/github/workspace/src/12757782.patch total: 0 errors, 1 warnings, 189 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12757782.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

[3/7] mesh: Add common MGMT command accessors
WARNING:TYPO_SPELLING: 'accross' may be misspelled - perhaps 'across'?
#69:
a single socket, shared accross all consumers.
^^^^^^^

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - void mesh_mgmt_destroy() should probably be void mesh_mgmt_destroy(void)
#285: FILE: mesh/mesh-mgmt.c:226:
+void mesh_mgmt_destroy()

/github/workspace/src/12757783.patch total: 1 errors, 1 warnings, 243 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12757783.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

[4/7] mesh: rework Mesh-IO for multiple transports
WARNING:LINE_SPACING: Missing a blank line after declarations
#334: FILE: mesh/mesh-io-mgmt.c:108:
+ const struct dup_filter *filter = a;
+ return !memcmp(filter->addr, b, 6);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#337: FILE: mesh/mesh-io-mgmt.c:111:
+static void filter_timeout (struct l_timeout *timeout, void *user_data)

ERROR:CODE_INDENT: code indent should use tabs where possible
#367: FILE: mesh/mesh-io-mgmt.c:141:
+ uint32_t instant)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#367: FILE: mesh/mesh-io-mgmt.c:141:
+ uint32_t instant)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#465: FILE: mesh/mesh-io-mgmt.c:239:
+ if (adv[1] >= 0x29 && adv[1] <= 0x2B)
+ process_rx(io->pvt, ev->rssi, instant, addr, adv + 1, adv[0]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1102: FILE: mesh/mesh-io.c:51:
+ if (table[i].type == type) {
+ return table[i].api;
+ }

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1173: FILE: mesh/mesh-io.c:97:
+ if (mesh && type != MESH_IO_TYPE_GENERIC) {
[...]
- if (l_queue_push_head(io_list, io))
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1179: FILE: mesh/mesh-io.c:101:
+ else if (!pwr) {
+ api = io_api(MESH_IO_TYPE_GENERIC);
+ }

/github/workspace/src/12757784.patch total: 1 errors, 7 warnings, 1227 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/12757784.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: Incremental Build with patches - FAIL
Desc: Incremental build per patch in the series
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12364 | int main(int argc, char *argv[])
| ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
766 | int main(int argc, char *argv[])
| ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
989 | int main(int argc, char *argv[])
| ^~~~
In file included from mesh/mesh-io-generic.c:26:
./mesh/mesh-mgmt.h:18:5: error: unknown type name ‘mgmt_request_func_t’
18 | mgmt_request_func_t callback,
| ^~~~~~~~~~~~~~~~~~~
./mesh/mesh-mgmt.h:19:22: error: unknown type name ‘mgmt_destroy_func_t’; did you mean ‘bt_hci_destroy_func_t’?
19 | void *user_data, mgmt_destroy_func_t destroy);
| ^~~~~~~~~~~~~~~~~~~
| bt_hci_destroy_func_t
./mesh/mesh-mgmt.h:21:5: error: unknown type name ‘mgmt_notify_func_t’
21 | mgmt_notify_func_t callback,
| ^~~~~~~~~~~~~~~~~~
./mesh/mesh-mgmt.h:22:22: error: unknown type name ‘mgmt_destroy_func_t’; did you mean ‘bt_hci_destroy_func_t’?
22 | void *user_data, mgmt_destroy_func_t destroy);
| ^~~~~~~~~~~~~~~~~~~
| bt_hci_destroy_func_t
mesh/mesh-io-generic.c: In function ‘dev_init’:
mesh/mesh-io-generic.c:448:25: error: passing argument 1 of ‘mesh_mgmt_list’ from incompatible pointer type [-Werror=incompatible-pointer-types]
448 | return mesh_mgmt_list(read_info, io);
| ^~~~~~~~~
| |
| void (*)(int, void *)
In file included from mesh/mesh-io-generic.c:26:
./mesh/mesh-mgmt.h:15:48: note: expected ‘mesh_mgmt_read_info_func_t’ {aka ‘void (*)(int, _Bool, _Bool, _Bool, void *)’} but argument is of type ‘void (*)(int, void *)’
15 | bool mesh_mgmt_list(mesh_mgmt_read_info_func_t cb, void *user_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7271: mesh/mesh-io-generic.o] Error 1
make: *** [Makefile:4307: all] Error 2

---
Regards,
Linux Bluetooth