2022-12-02 21:39:35

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Fix not cleanup led when bt_init fails

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 29 Nov 2022 17:25:56 +0800 you wrote:
> bt_init() calls bt_leds_init() to register led, but if it fails later,
> bt_leds_cleanup() is not called to unregister it.
>
> This can cause panic if the argument "bluetooth-power" in text is freed
> and then another led_trigger_register() tries to access it:
>
> BUG: unable to handle page fault for address: ffffffffc06d3bc0
> RIP: 0010:strcmp+0xc/0x30
> Call Trace:
> <TASK>
> led_trigger_register+0x10d/0x4f0
> led_trigger_register_simple+0x7d/0x100
> bt_init+0x39/0xf7 [bluetooth]
> do_one_initcall+0xd0/0x4e0
>
> [...]

Here is the summary with links:
- Bluetooth: Fix not cleanup led when bt_init fails
https://git.kernel.org/bluetooth/bluetooth-next/c/63d70ae785a9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html