2023-01-18 13:16:14

by Francesco Dolcini

[permalink] [raw]
Subject: [PATCH v1 2/4] dt-bindings: bluetooth: marvell: add max-speed property

From: Stefan Eichenberger <[email protected]>

The 88W8997 bluetooth module supports setting the max-speed property.

Signed-off-by: Stefan Eichenberger <[email protected]>
Signed-off-by: Francesco Dolcini <[email protected]>
---
.../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
index 83b64ed730f5..2fccea30c58d 100644
--- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
@@ -19,9 +19,25 @@ properties:
- mrvl,88w8897
- mrvl,88w8997

+ max-speed:
+ description: see Documentation/devicetree/bindings/serial/serial.yaml
+
required:
- compatible

+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mrvl,88w8997
+ then:
+ properties:
+ max-speed: true
+ else:
+ properties:
+ max-speed: false
+
additionalProperties: false

examples:
--
2.25.1


2023-01-19 12:01:48

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 2/4] dt-bindings: bluetooth: marvell: add max-speed property

On 18/01/2023 13:28, Francesco Dolcini wrote:
> From: Stefan Eichenberger <[email protected]>
>
> The 88W8997 bluetooth module supports setting the max-speed property.
>
> Signed-off-by: Stefan Eichenberger <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>
> ---
> .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> index 83b64ed730f5..2fccea30c58d 100644
> --- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> @@ -19,9 +19,25 @@ properties:
> - mrvl,88w8897
> - mrvl,88w8997
>
> + max-speed:
> + description: see Documentation/devicetree/bindings/serial/serial.yaml
> +
> required:
> - compatible
>
> +allOf:
> + - if:
> + properties:

Wrong indentation, missing two spaces.

Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

Best regards,
Krzysztof