2023-03-15 17:37:11

by Chris Morgan

[permalink] [raw]
Subject: [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS

From: Chris Morgan <[email protected]>

This patch series is to add support for the RTL8821CS Bluetooth
controller found on the RTL8821CS WiFi/Bluetooth combo chip.

This has been tested with firmware version 0x75b8f098 which has been
submitted by Realtek for inclusion in linux-firmware.

https://lore.kernel.org/linux-firmware/[email protected]/

Changes from V4:
- After extensive testing it was found that there are problems with
using the bluetooth that were not caught with the initial testing.
This can be mitigated by setting the "H5_INFO_WAKEUP_DISABLE" flag.
The easiest way to accomplish that is to change the fallback
compatible string to "realtek,rtl8723bs-bt". Updated the binding
documentation and binding to reflect this. No change to the driver
from V4 was necessary. Removed "reviewed-by" from documentation due
to this change.

Changes from V3:
- Corrected bindings so that all but the 8821 use enum, and 8821 uses
items.

Changes from V2:
- Corrected devicetree documentation to change compatible from const
back to enum.
- Removed "reviewed-by" from Alistair Francis as binding documentation
updated with changes.

Changes from V1:
- Switched to use a fallback string for the rtl8822cs so as to not add
an extra entry to the of_device_id table. The driver is capable of
selecting the correct firmware blob to load.
- Updated the messages to note a new version of the firmware was
tested and that Realtek has submitted this firmware upstream.
- Updated the devicetree node on the Anbernic RGxx3 series to use the
fallback string of realtek,rtl8822cs-bt.

Chris Morgan (3):
dt-bindings: net: realtek-bluetooth: Add RTL8821CS
Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
arm64: dts: rockchip: Update compatible for bluetooth

.../bindings/net/realtek-bluetooth.yaml | 24 ++++++++++++-------
.../dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
drivers/bluetooth/btrtl.c | 8 +++++++
3 files changed, 24 insertions(+), 10 deletions(-)

--
2.34.1



2023-03-15 17:37:12

by Chris Morgan

[permalink] [raw]
Subject: [PATCH 2/3 V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS

From: Chris Morgan <[email protected]>

RTL8821CS is a WiFi + Bluetooth combo chip from Realtek that provides
WiFi A/B/G/N/AC over an SDIO interface and Bluetooth 4.2 over a UART
interface.

Note that the firmware this was tested with was firmware version
0x75b8f098.

Signed-off-by: Chris Morgan <[email protected]>
---
drivers/bluetooth/btrtl.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 69c3fe649ca7..72947d319fa6 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -128,6 +128,14 @@ static const struct id_table ic_id_table[] = {
.fw_name = "rtl_bt/rtl8821c_fw.bin",
.cfg_name = "rtl_bt/rtl8821c_config" },

+ /* 8821CS */
+ { IC_INFO(RTL_ROM_LMP_8821A, 0xc, 0x8, HCI_UART),
+ .config_needed = true,
+ .has_rom_version = true,
+ .has_msft_ext = true,
+ .fw_name = "rtl_bt/rtl8821cs_fw.bin",
+ .cfg_name = "rtl_bt/rtl8821cs_config" },
+
/* 8761A */
{ IC_INFO(RTL_ROM_LMP_8761A, 0xa, 0x6, HCI_USB),
.config_needed = false,
--
2.34.1


2023-03-22 23:45:41

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 15 Mar 2023 12:36:54 -0500 you wrote:
> From: Chris Morgan <[email protected]>
>
> This patch series is to add support for the RTL8821CS Bluetooth
> controller found on the RTL8821CS WiFi/Bluetooth combo chip.
>
> This has been tested with firmware version 0x75b8f098 which has been
> submitted by Realtek for inclusion in linux-firmware.
>
> [...]

Here is the summary with links:
- [1/3,V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
(no matching commit)
- [2/3,V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
https://git.kernel.org/bluetooth/bluetooth-next/c/60f8c67d065a
- [3/3,V5] arm64: dts: rockchip: Update compatible for bluetooth
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html