2023-12-07 13:08:00

by Northfield Stuart

[permalink] [raw]
Subject: [PATCH BlueZ v1] client: make ad_clear_data() clear the correct structure

Fix longstanding ‘cut and paste’ bug which clears Manfacturer Data
structure when it should be clearing Data structure

---
diff --git a/client/advertising.c b/client/advertising.c
index a7474d6a2..b8e3f4ab3 100644
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -757,7 +757,7 @@ void ad_disable_manufacturer(DBusConnection *conn)
static void ad_clear_data(void)
{
- memset(&ad.manufacturer, 0, sizeof(ad.manufacturer));
+ memset(&ad.data, 0, sizeof(ad.data));
return bt_shell_noninteractive_quit(EXIT_SUCCESS);
}








2023-12-07 13:16:52

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1] client: make ad_clear_data() clear the correct structure

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: client/advertising.c:757
error: client/advertising.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth