2023-12-22 11:41:06

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: Fix atomicity violation in {conn,adv}_{min,max}_interval_set

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=812452

---Test result---

Test Summary:
CheckPatch FAIL 0.79 seconds
GitLint FAIL 4.01 seconds
SubjectPrefix PASS 0.35 seconds
BuildKernel PASS 28.00 seconds
CheckAllWarning PASS 30.53 seconds
CheckSparse PASS 35.88 seconds
CheckSmatch PASS 104.39 seconds
BuildKernel32 PASS 26.97 seconds
TestRunnerSetup PASS 434.35 seconds
TestRunner_l2cap-tester PASS 23.45 seconds
TestRunner_iso-tester PASS 46.45 seconds
TestRunner_bnep-tester PASS 7.35 seconds
TestRunner_mgmt-tester FAIL 168.91 seconds
TestRunner_rfcomm-tester PASS 11.21 seconds
TestRunner_sco-tester PASS 14.81 seconds
TestRunner_ioctl-tester PASS 12.41 seconds
TestRunner_mesh-tester PASS 9.02 seconds
TestRunner_smp-tester PASS 9.93 seconds
TestRunner_userchan-tester PASS 7.40 seconds
IncrementalBuild PASS 26.56 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: Fix atomicity violation in {conn,adv}_{min,max}_interval_set
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: ("Bluetooth: Move LE debugfs file creation into ...")'
#121:
Fixes: 3a5c82b78fd28 ("Bluetooth: Move LE debugfs file creation into ...")

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#123:
Reported-by: BassCheck <[email protected]>
Signed-off-by: Gui-Dong Han <[email protected]>

ERROR: trailing whitespace
#139: FILE: net/bluetooth/hci_debugfs.c:852:
+^I$

ERROR: trailing whitespace
#142: FILE: net/bluetooth/hci_debugfs.c:855:
+^I^Ihci_dev_unlock(hdev);^I$

ERROR: trailing whitespace
#156: FILE: net/bluetooth/hci_debugfs.c:882:
+^I$

ERROR: trailing whitespace
#173: FILE: net/bluetooth/hci_debugfs.c:996:
+^I$

ERROR: trailing whitespace
#176: FILE: net/bluetooth/hci_debugfs.c:999:
+^I^Ihci_dev_unlock(hdev);^I$

total: 5 errors, 2 warnings, 0 checks, 62 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/src/13503199.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


Use of uninitialized value $cid in concatenation (.) or string at /github/workspace/src/src/scripts/checkpatch.pl line 3228.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: Fix atomicity violation in {conn,adv}_{min,max}_interval_set

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
4: B3 Line contains hard tab characters (\t): " if (val < ... || val > ... || val > hdev->le_{conn,adv}_max_interval)"
5: B3 Line contains hard tab characters (\t): " return -EINVAL;"
6: B3 Line contains hard tab characters (\t): " hci_dev_lock(hdev);"
7: B3 Line contains hard tab characters (\t): " hdev->le_{conn,adv}_min_interval = val;"
8: B3 Line contains hard tab characters (\t): " hci_dev_unlock(hdev);"
11: B3 Line contains hard tab characters (\t): " if (val < ... || val > ... || val < hdev->le_{conn,adv}_min_interval)"
12: B3 Line contains hard tab characters (\t): " return -EINVAL;"
13: B3 Line contains hard tab characters (\t): " hci_dev_lock(hdev);"
14: B3 Line contains hard tab characters (\t): " hdev->le_{conn,adv}_max_interval"
15: B3 Line contains hard tab characters (\t): " hci_dev_unlock(hdev);"
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 497, Passed: 495 (99.6%), Failed: 1, Not Run: 1

Failed Test Cases
LL Privacy - Start Discovery 2 (Disable RL) Failed 0.336 seconds


---
Regards,
Linux Bluetooth