2024-01-12 18:38:11

by fdanis-oss

[permalink] [raw]
Subject: [bluez/bluez] 1f9ff8: avdtp: Fix potential incorrect transaction label

Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: 1f9ff8fb4048189c762ff83fa20b1cf3ab2973ad
https://github.com/bluez/bluez/commit/1f9ff8fb4048189c762ff83fa20b1cf3ab2973ad
Author: Xiao Yao <[email protected]>
Date: 2024-01-12 (Fri, 12 Jan 2024)

Changed paths:
M profiles/audio/avdtp.c

Log Message:
-----------
avdtp: Fix potential incorrect transaction label

Currently, AVDTP commands and responses from remote devices are all
stored in session.in. When one end has an ongoing transaction and
immediately starting another transaction, it may cause the session.
in.transaction to be incorrectly modified, so we need session.in_cmd
and session.in_rsp to be able to handle outstanding requests in each
direction.

After applying this patch, the problem no longer recurs. Apply this
patch to android/avdtp.c and run:

> unit/test-avdtp
Test Summary
------------
/TP/SIG/SMG/BV-06-C-SEID-1 Passed 0.004 seconds
... ...
/TP/SIG/SYN/BV-06-C Passed 0.001 seconds
Total: 62, Passed: 62 (100.0%), Failed: 0, Not Run: 0
Overall execution time: 1.76 seconds