DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 127E62082C
Subject: Re: [PATCH 1/1] Add interface udev_domtrans_to
To:     Dave Sugar <dsugar@tresys.com>, selinux-refpolicy@vger.kernel.org
References: <20181017141949.17119-1-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <a63fac38-8c33-13f3-e386-a15bb4bd57b4@ieee.org>
Date:   Sat, 27 Oct 2018 15:13:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181017141949.17119-1-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 10/17/2018 10:19 AM, Dave Sugar wrote:
> This interface is useful when using the 'RUN' option in UDEV rules where udev will be executing a user function to perform some action.  This interface allows a domain transition to occur for the run action.
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/system/udev.if | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
> 
> diff --git a/policy/modules/system/udev.if b/policy/modules/system/udev.if
> index a2067895..45ab498c 100644
> --- a/policy/modules/system/udev.if
> +++ b/policy/modules/system/udev.if
> @@ -36,6 +36,41 @@ interface(`udev_domtrans',`
>   	domtrans_pattern($1, udev_exec_t, udev_t)
>   ')
>   
> +########################################
> +## <summary>
> +##	Allow udev to execute the specified program in
> +##	the specified domain.
> +## </summary>
> +## <desc>
> +##	<p>
> +##	Allow udev to execute the specified program in
> +##	the specified domain.
> +##	</p>
> +##	<p>
> +##	This is an interface to support the UDEV 'RUN'
> +##	command.  This will allow the command run by
> +##	udev to be run in a domain other than udev_t.
> +##	</p>
> +## </desc>
> +## <param name="domain">
> +##	<summary>
> +##	Domain to execute in.
> +##	</summary>
> +## </param>
> +## <param name="entry_file">
> +##	<summary>
> +##	Domain entry point file.
> +##	</summary>
> +## </param>
> +#
> +interface(`udev_domtrans_to',`

This should be called something like udev_run_command_domain or 
udev_run_domain.  If you have other suggestions, I could take that too, 
since this being for "run commands" doesn't make interface naming easy.


> +	gen_require(`
> +		type udev_t;
> +	')
> +
> +	domtrans_pattern(udev_t,$2,$1)
> +')
> +
>   ########################################
>   ## <summary>
>   ##	Execute udev in the caller domain.
> 


-- 
Chris PeBenito