Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A430AC0044C for ; Sat, 10 Nov 2018 00:43:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69A8E20855 for ; Sat, 10 Nov 2018 00:43:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="C1my7r24" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A8E20855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ieee.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728396AbeKJK0J (ORCPT ); Sat, 10 Nov 2018 05:26:09 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:43096 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727730AbeKJK0J (ORCPT ); Sat, 10 Nov 2018 05:26:09 -0500 Received: by mail-qk1-f196.google.com with SMTP id r71so4842448qkr.10 for ; Fri, 09 Nov 2018 16:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Cy7O2JIsa7ND+Yrn2HfSjB6Z4As3znvT7x1rZjjHPjI=; b=C1my7r24eh/ZyeDEJqAzQEbiKGk31OWJTd5696niP20tYhvIf8ko0qN5HMRsJII4ZK yqgFhI3OJo2IybybscFb4KqgiIGT5lnNu/cKOjnfwGVxMoFuTa+clR1DXTfCvLoq0/9i r80Ys6P9+kboHXjd29ICswbycc+W3YMgW/pas= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cy7O2JIsa7ND+Yrn2HfSjB6Z4As3znvT7x1rZjjHPjI=; b=sNov9jiiYDD0wHLd8MJnkczEGlGo20w6+Lf/rkehKLv0rjQ4R7bi0nQf8jChSmO44Z lOiG5YXLKleXbDLWAiWRgbkyxANHHNrxqXoWIcxmPtuiCT2eG+4b0yjn7nqF7xP21t3g S65cY1W9n9qMW5keVKInKbXGsC1vOl9u1ai0pVfB+n4PNWBMantGsmMqv6pb+APOxuHT gSaBGsNFzaBDU0+Q1XgVJ3/qEYBiBWlFLfmqz2RbxQxsetZ9+tlo3h/1xbU9MsAx2lYx hdjA/Dy+StTs0TuZDsDnytQ8sWBPUqj/QR9i/9qFK1z2p2+HvJ6HhLxuE0/p0MpH7Ne4 ZUAQ== X-Gm-Message-State: AGRZ1gI+jtAMaeYcnDs13ttSf/5Svgscu7Tk9HfATeDiVJ/kN7G193Vl FOa1yyOhGef5eaMKTKJ3H6mbPjBwrE0eEqaf X-Google-Smtp-Source: AJdET5cRiHeWHIsbZVoUaVSGpJFBAvfbUHSmwR+KqBSZ4wwbtSLw7fvH+nfwrsEsFbbK9QKurQf8hA== X-Received: by 2002:a0c:b301:: with SMTP id s1mr10857586qve.132.1541810583893; Fri, 09 Nov 2018 16:43:03 -0800 (PST) Received: from [192.168.1.190] (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id e17sm5582265qte.12.2018.11.09.16.43.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Nov 2018 16:43:03 -0800 (PST) Subject: Re: [PATCH 1/3] Allow clamd_t to read /proc/sys/crypt/fips_enabled To: David Sugar , "selinux-refpolicy@vger.kernel.org" References: <20181102003727.22500-1-dsugar@tresys.com> From: Chris PeBenito Message-ID: <1572af1d-38b0-7aad-6d86-c9d3da8dc98e@ieee.org> Date: Fri, 9 Nov 2018 19:07:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181102003727.22500-1-dsugar@tresys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 11/01/2018 08:38 PM, David Sugar wrote: > > To fix the following denials: > type=AVC msg=audit(1540821927.216:215): avc: denied { search } for > pid=1726 comm="clamd" name="crypto" dev="proc" ino=68 > scontext=system_u:system_r:clamd_t:s0 > tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=dir > type=AVC msg=audit(1540821927.216:215): avc: denied { read } for > pid=1726 comm="clamd" name="fips_enabled" dev="proc" ino=69 > scontext=system_u:system_r:clamd_t:s0 > tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file > type=AVC msg=audit(1540821927.216:215): avc: denied { open } for > pid=1726 comm="clamd" path="/proc/sys/crypto/fips_enabled" dev="proc" > ino=69 scontext=system_u:system_r:clamd_t:s0 > tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file > type=AVC msg=audit(1540821927.216:216): avc: denied { getattr } for > pid=1726 comm="clamd" path="/proc/sys/crypto/fips_enabled" dev="proc" > ino=69 scontext=system_u:system_r:clamd_t:s0 > tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file > > Signed-off-by: Dave Sugar > --- > policy/modules/services/clamav.te | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/policy/modules/services/clamav.te b/policy/modules/services/clamav.te > index 5db29776..a2f30133 100644 > --- a/policy/modules/services/clamav.te > +++ b/policy/modules/services/clamav.te > @@ -104,6 +104,7 @@ manage_sock_files_pattern(clamd_t, clamd_var_run_t, clamd_var_run_t) > files_pid_filetrans(clamd_t, clamd_var_run_t, { dir file sock_file }) > > kernel_dontaudit_list_proc(clamd_t) > +kernel_read_crypto_sysctls(clamd_t) > kernel_read_sysctl(clamd_t) > kernel_read_kernel_sysctls(clamd_t) > kernel_read_system_state(clamd_t) Merged. -- Chris PeBenito