DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BF352081C
Subject: Re: [PATCH 1/2] dnsmasq: Require log files to have .log suffix
To:     Petr Vorel <pvorel@suse.cz>, selinux-refpolicy@vger.kernel.org
Cc:     Dan Walsh <dwalsh@redhat.com>
References: <20181107205736.21748-1-pvorel@suse.cz>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <5137d6d9-5bdb-a21d-97c9-2e6c8a61c2a6@ieee.org>
Date:   Fri, 9 Nov 2018 19:25:46 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181107205736.21748-1-pvorel@suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 11/07/2018 03:57 PM, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>   policy/modules/services/dnsmasq.fc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/policy/modules/services/dnsmasq.fc b/policy/modules/services/dnsmasq.fc
> index 29d71c91..4c34df3c 100644
> --- a/policy/modules/services/dnsmasq.fc
> +++ b/policy/modules/services/dnsmasq.fc
> @@ -13,7 +13,7 @@
>   /var/lib/misc/dnsmasq\.leases	--	gen_context(system_u:object_r:dnsmasq_lease_t,s0)
>   /var/lib/dnsmasq(/.*)?	gen_context(system_u:object_r:dnsmasq_lease_t,s0)
>   
> -/var/log/dnsmasq.*	--	gen_context(system_u:object_r:dnsmasq_var_log_t,s0)
> +/var/log/dnsmasq(.*)?\.log	--	gen_context(system_u:object_r:dnsmasq_var_log_t,s0)
>   
>   /run/dnsmasq.*	--	gen_context(system_u:object_r:dnsmasq_var_run_t,s0)
>   /run/libvirt/network(/.*)?	gen_context(system_u:object_r:dnsmasq_var_run_t,s0)

This would exclude rotated logs, e.g. something like dnsmasq.log.1 or 
dnsmasq.log.1.gz, which would be undesirable.

-- 
Chris PeBenito