Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17114C43441 for ; Sat, 17 Nov 2018 23:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A90A920684 for ; Sat, 17 Nov 2018 23:50:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="EV8EePBZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A90A920684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ieee.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbeKRKI6 (ORCPT ); Sun, 18 Nov 2018 05:08:58 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:43754 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbeKRKI6 (ORCPT ); Sun, 18 Nov 2018 05:08:58 -0500 Received: by mail-qk1-f193.google.com with SMTP id r71so43389631qkr.10 for ; Sat, 17 Nov 2018 15:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6Nya4nW1MNskSzlgxsAIfQRQN+nGXF/SyoQ16UX4wk4=; b=EV8EePBZgC5UsXDvMMlVSN6IIfcTKfiXfBgFdWsNMMVbsw6mBj8kKcf0Qhm3BpSZkY DX9paebPNibEiY99zkhvBUXDW/vb4rOZAhPsaf6dpwQx9ICPN1V+uZeSaVCztGSZOb2J FAJkRGg1mj4Ldz1GW9yauwHH6O2QUEfdGi8HA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Nya4nW1MNskSzlgxsAIfQRQN+nGXF/SyoQ16UX4wk4=; b=Jni4lmlEW9LhEDVKhUIMVlyxXaFfrAufk8Or9vj+TPNO/Eyn4FbBP9cyPBxv3e30XW Gmhya0/XcFlUoWmTeJvTFOfrFEaM3LRngJlkNUoEL2I6E6cNcEDQ8uwiPOPXnrb2AesN uGORrvIvGjYpc89DaedAdD76w0JlGzMZmz8gia1XzlDaBHM5wM8UUY+NhEMIsea67iVW zhAFVgS1y3elxniwr2EqxYwe7FZKVNUsR2Ztp0wnaYzuwJdQoB9W8nQWmksHthzLGAOU mFHetZBlY0nd8bY6EnGTb6p+ihHDuRVeC25evkLwdzuxF5j5Rjvx92kHOx4GTssX17YS lgvg== X-Gm-Message-State: AGRZ1gJCzUgWoqxtUFTsrLU9iT8+xcHPgGi/K273+0b823I61yM0UvmU V4VjOHgEqX4EP/Z+pQfVXZJZFQ== X-Google-Smtp-Source: AJdET5dpfcWK6fYD+5aPK4mIeSWz8jL/Wsa+kUomHHMf6RKE5iTzx7orOY1ixmT4fz6iv9SSeQKXXA== X-Received: by 2002:a37:5f82:: with SMTP id t124mr15416673qkb.204.1542498633112; Sat, 17 Nov 2018 15:50:33 -0800 (PST) Received: from [192.168.1.190] (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id k132sm15031271qke.36.2018.11.17.15.50.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Nov 2018 15:50:32 -0800 (PST) Subject: Re: [PATCH v3 1/2] dnsmasq: Require log files to have .log suffix To: Petr Vorel , selinux-refpolicy@vger.kernel.org Cc: Dan Walsh References: <20181112084731.27185-1-pvorel@suse.cz> From: Chris PeBenito Message-ID: <23f142fd-06a6-4b4f-c9e8-ca71f8407d27@ieee.org> Date: Sat, 17 Nov 2018 18:50:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181112084731.27185-1-pvorel@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 11/12/18 3:47 AM, Petr Vorel wrote: > + allow log rotate as well. > > Signed-off-by: Petr Vorel > --- > Changes v1->v2 > * support log rotate patterns (requested by Chris PeBenito) > > Changes v2->v3: > * update to current master > --- > policy/modules/services/dnsmasq.fc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/policy/modules/services/dnsmasq.fc b/policy/modules/services/dnsmasq.fc > index a6d7f115..91c18d46 100644 > --- a/policy/modules/services/dnsmasq.fc > +++ b/policy/modules/services/dnsmasq.fc > @@ -16,4 +16,4 @@ > /var/lib/misc/dnsmasq\.leases -- gen_context(system_u:object_r:dnsmasq_lease_t,s0) > /var/lib/dnsmasq(/.*)? gen_context(system_u:object_r:dnsmasq_lease_t,s0) > > -/var/log/dnsmasq.* -- gen_context(system_u:object_r:dnsmasq_var_log_t,s0) > +/var/log/dnsmasq(.*)?\.log(\..+) -- gen_context(system_u:object_r:dnsmasq_var_log_t,s0) Merged. -- Chris PeBenito