Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B32C04EB8 for ; Fri, 7 Dec 2018 00:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 969E220868 for ; Fri, 7 Dec 2018 00:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=tresys.onmicrosoft.com header.i=@tresys.onmicrosoft.com header.b="dJAQqSH5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 969E220868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tresys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725945AbeLGAUP (ORCPT ); Thu, 6 Dec 2018 19:20:15 -0500 Received: from mail-eopbgr700097.outbound.protection.outlook.com ([40.107.70.97]:33232 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725944AbeLGAUP (ORCPT ); Thu, 6 Dec 2018 19:20:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tresys.onmicrosoft.com; s=selector1-tresys-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W1BzOBHx9c8HmAmrpOB3W3wDX1fjJHxIGM/QNbYs3+g=; b=dJAQqSH5e528tEp34sB5AVC4JRYnrUgjb5MitkYon6guXP1jMGsDFhOPJXHLL0Qs05Rb9s+3cN2WkYX2fy6yjLlZTGl/HUjGmxtBdltsoSpYOQnXu7JS5bCEvmjMSe6065fxsF2j+KZxtJT0rbZYn+nXXeWWlGJ8YUtMFpE2FxU= Received: from BN6PR15MB1507.namprd15.prod.outlook.com (10.172.151.147) by BN6PR15MB1636.namprd15.prod.outlook.com (10.175.131.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.21; Fri, 7 Dec 2018 00:20:11 +0000 Received: from BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::19a7:1a53:2419:2929]) by BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::19a7:1a53:2419:2929%11]) with mapi id 15.20.1382.023; Fri, 7 Dec 2018 00:20:11 +0000 From: David Sugar To: "selinux-refpolicy@vger.kernel.org" Subject: [PATCH] Allow auditctl_t to read bin_t symlinks. Thread-Topic: [PATCH] Allow auditctl_t to read bin_t symlinks. Thread-Index: AQHUjcKd2NW1498daEGU2sUG+SXuDg== Date: Fri, 7 Dec 2018 00:20:11 +0000 Message-ID: <20181207001935.16566-1-dsugar@tresys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [173.8.5.193] x-clientproxiedby: BN6PR11CA0004.namprd11.prod.outlook.com (2603:10b6:405:2::14) To BN6PR15MB1507.namprd15.prod.outlook.com (2603:10b6:404:c6::19) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR15MB1636;6:44yCgxDmKszLWNk/w6nhiJJwW4v6mfgr8ZhnabU9r+0UbafgFbqhacbpadGB7liFdSQBaWG60pD81ksvHvwWyGrQJ3LyetnV291fwZsnol/lSTEODT3fdHhw+ZRwh54I4D5zXglJzVbGvlLEfuUf1zbdN4eizfiih0qAtgkDfMBlHWp9eMAQnrfsnirAnXjhbm0cQEstLjW63/gJsJIVppxcHBTB84ap4zcX6zvqCynCzhLC5eFhiRFeVCw5m37uY52C5hBtHHtj0UHVdBxILRx5/bTKIXekqUrHgXlZC/0zbbzMHtjI8nYzUOegesVBDPgdXkugKpXz3yU5qAGVTm2G4eh0p50rNbPAFAvYbDSZsO4hDYH8MTsQSZaSeeBo/GKd7ziYw8+n74I5Ib+2FdLeKlSVuMYB5t6RhtEAQSCOfGTaXx1IKFooGyYXSwzjozUBklw+YNm8bdCE7j8PjQ==;5:6D/ncR9A5I3znB1BLuw2wgqAmgNzXSpcCRSas+njyy6BG4xAcIy6HrY8zT24j7XFrpytZek0abqMos1NGnyxzFPnT/GNTpErQB4cJ5GUeWNggCdo5eFY4L6P1kcxTIb/R7unmWE1SUWGgQUEP8Dw5lC9fg+n9H+9Fs+UoQZUQ7Y=;7:H6sVo7aPzNvr+wv0JNj+MRBIjeWo+8JDLBtk530snjcbDLzgu1cM3cFwGuYqFoQvhkMWl8bn0NfNTeyZjikggjl+m6DihYC7Y45+0G45KAh78cjpCOj2IpA7nEGCxCsH50oR04HCIosg2NkcaXfLog== x-ms-office365-filtering-correlation-id: aff7eabd-050e-445f-dca1-08d65bd9c04f x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BN6PR15MB1636; x-ms-traffictypediagnostic: BN6PR15MB1636: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dsugar@tresys.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(2016111802025)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6043046)(201708071742011)(7699051)(76991095);SRVR:BN6PR15MB1636;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1636; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(39830400003)(346002)(136003)(189003)(199004)(25786009)(5640700003)(508600001)(36756003)(6486002)(66066001)(1076002)(256004)(305945005)(6116002)(86362001)(6916009)(3846002)(2906002)(8676002)(71200400001)(7736002)(14454004)(8936002)(6512007)(2351001)(486006)(106356001)(53936002)(71190400001)(52116002)(81156014)(81166006)(476003)(2616005)(2501003)(99286004)(316002)(97736004)(5660300001)(186003)(68736007)(6436002)(102836004)(105586002)(386003)(6506007)(26005);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1636;H:BN6PR15MB1507.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: tresys.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: hEunFg2E7WKVkUXNcUn9AUZGvIhxWkSRW3mzNNBhBXThuBZ7vrUMpUYHLN9EsjWnojqySFwroVISeCBpewwqLagzLJDUgw3qt0NvbJC1QYwtXyjQgauM35LuFN+2ibOUqNCiV8GjgAggoozHWr1KD7Sbkx8yXHB4GBqnfu4Z9f10bspUf7/BQmBXujPKZtNo0c+gFdtNzPCXJrhUkqMk3rGg2VoGtJ2ZfbjsTUoDr0BfjJsIInAWGnM/i9udT5gQBR7H6epe0M5lTo+Kq3i1Xs64W7tQZn7cX/y6hUHtFmyipGsI730jn9sXgm9lj4DEc/Tcc5FegwBNALlTVU0UXjVt2b0ohSDlnASvrFucxe8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: tresys.com X-MS-Exchange-CrossTenant-Network-Message-Id: aff7eabd-050e-445f-dca1-08d65bd9c04f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 00:20:11.4566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a0d45667-6c07-4e88-868f-4ac9af95c7ed X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1636 Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org on RHEL7 insmod, rmmod, modprobe (and others?) are a symlinks to ../bin/kmod. But policy didn't allow auditctl_t to follow that link. type=3DAVC msg=3Daudit(1543853530.925:141): avc: denied { read } for pid=3D6937 comm=3D"auditctl" name=3D"insmod" dev=3D"dm-1" ino=3D628383 scontext=3Dsystem_u:system_r:auditctl_t:s0 tcontext=3Dsystem_u:object_r:bin_t:s0 tclass=3Dlnk_file permissive=3D0 type=3DAVC msg=3Daudit(1543853530.925:143): avc: denied { read } for pid=3D6937 comm=3D"auditctl" name=3D"rmmod" dev=3D"dm-1" ino=3D628387 scontext=3Dsystem_u:system_r:auditctl_t:s0 tcontext=3Dsystem_u:object_r:bin_t:s0 tclass=3Dlnk_file permissive=3D0 type=3DAVC msg=3Daudit(1543853530.926:145): avc: denied { read } for pid=3D6937 comm=3D"auditctl" name=3D"modprobe" dev=3D"dm-1" ino=3D628386 scontext=3Dsystem_u:system_r:auditctl_t:s0 tcontext=3Dsystem_u:object_r:bin_t:s0 tclass=3Dlnk_file permissive=3D0 type=3DAVC msg=3Daudit(1543853797.766:60): avc: denied { read } for pid=3D6942 comm=3D"auditctl" name=3D"insmod" dev=3D"dm-1" ino=3D628383 scontext=3Dsystem_u:system_r:auditctl_t:s0 tcontext=3Dsystem_u:object_r:bin_t:s0 tclass=3Dlnk_file permissive=3D1 Signed-off-by: Dave Sugar --- policy/modules/system/logging.te | 2 ++ 1 file changed, 2 insertions(+) diff --git a/policy/modules/system/logging.te b/policy/modules/system/loggi= ng.te index 7020a476..483084a5 100644 --- a/policy/modules/system/logging.te +++ b/policy/modules/system/logging.te @@ -107,6 +107,8 @@ read_files_pattern(auditctl_t, auditd_etc_t, auditd_etc= _t) allow auditctl_t auditd_etc_t:dir list_dir_perms; dontaudit auditctl_t auditd_etc_t:file map; =20 +corecmd_search_bin(auditctl_t) + # Needed for adding watches files_getattr_all_dirs(auditctl_t) files_getattr_all_files(auditctl_t) --=20 2.19.2