DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 011DE2084E
Subject: Re: [PATCH 3/3] Allow dbus to access /proc/sys/crypto/fips_enabled
To:     David Sugar <dsugar@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20181208184347.32575-1-dsugar@tresys.com>
 <20181208184347.32575-4-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <425c8f13-1019-5b46-307d-ecfe8b15aadc@ieee.org>
Date:   Tue, 11 Dec 2018 17:54:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20181208184347.32575-4-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 12/8/18 1:45 PM, David Sugar wrote:
> type=AVC msg=audit(1543769401.029:153): avc:  denied  { search } for
> pid=6676 comm="dbus-daemon" name="crypto" dev="proc" ino=10284
> scontext=system_u:system_r:system_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1543769401.029:153): avc:  denied  { read } for
> pid=6676 comm="dbus-daemon" name="fips_enabled" dev="proc" ino=10285
> scontext=system_u:system_r:system_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> type=AVC msg=audit(1543769401.029:153): avc:  denied  { open } for
> pid=6676 comm="dbus-daemon" path="/proc/sys/crypto/fips_enabled"
> dev="proc" ino=10285
> scontext=system_u:system_r:system_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> type=AVC msg=audit(1543769401.029:154): avc:  denied  { getattr } for
> pid=6676 comm="dbus-daemon" path="/proc/sys/crypto/fips_enabled"
> dev="proc" ino=10285
> scontext=system_u:system_r:system_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> 
> type=AVC msg=audit(1543845518.175:364): avc:  denied  { search } for
> pid=10300 comm="dbus-daemon" name="crypto" dev="proc" ino=9288
> scontext=sysadm_u:sysadm_r:sysadm_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1543845518.175:364): avc:  denied  { read } for
> pid=10300 comm="dbus-daemon" name="fips_enabled" dev="proc" ino=9289
> scontext=sysadm_u:sysadm_r:sysadm_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> type=AVC msg=audit(1543845518.175:364): avc:  denied  { open } for
> pid=10300 comm="dbus-daemon" path="/proc/sys/crypto/fips_enabled"
> dev="proc" ino=9289
> scontext=sysadm_u:sysadm_r:sysadm_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> type=AVC msg=audit(1543845518.175:365): avc:  denied  { getattr } for
> pid=10300 comm="dbus-daemon" path="/proc/sys/crypto/fips_enabled"
> dev="proc" ino=9289
> scontext=sysadm_u:sysadm_r:sysadm_dbusd_t:s0-s0:c0.c1023
> tcontext=system_u:object_r:sysctl_crypto_t:s0 tclass=file permissive=1
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/services/dbus.te | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/policy/modules/services/dbus.te b/policy/modules/services/dbus.te
> index 4b1e25c6..ea0af022 100644
> --- a/policy/modules/services/dbus.te
> +++ b/policy/modules/services/dbus.te
> @@ -89,6 +89,7 @@ files_pid_filetrans(system_dbusd_t, system_dbusd_var_run_t, { dir file })
>   
>   can_exec(system_dbusd_t, dbusd_exec_t)
>   
> +kernel_read_crypto_sysctls(system_dbusd_t)
>   kernel_read_system_state(system_dbusd_t)
>   kernel_read_kernel_sysctls(system_dbusd_t)
>   
> @@ -227,6 +228,7 @@ manage_files_pattern(session_bus_type, session_dbusd_runtime_t, session_dbusd_ru
>   manage_sock_files_pattern(session_bus_type, session_dbusd_runtime_t, session_dbusd_runtime_t)
>   userdom_user_runtime_filetrans(session_bus_type, session_dbusd_runtime_t, { dir file sock_file })
>   
> +kernel_read_crypto_sysctls(session_bus_type)
>   kernel_read_system_state(session_bus_type)
>   kernel_read_kernel_sysctls(session_bus_type)

Merged.

-- 
Chris PeBenito