Subject: Re: [PATCH 2/2 v3] pam_faillock creates files in /run/faillock
To:     "Sugar, David" <dsugar@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20190106182922.20344-1-dsugar@tresys.com>
 <20190106182922.20344-2-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <891bd39b-a373-6820-a797-8948e4c16e44@ieee.org>
Date:   Sun, 6 Jan 2019 13:57:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190106182922.20344-2-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/6/19 1:31 PM, Sugar, David wrote:
> These are changes needed when pam_fallock creates files in /run/faillock
> (which is labeled faillog_t).  sudo and xdm (and probably other domains)
> will create files in this directory for successful and failed login
> attempts.
> 
> v3 - Updated based on feedback
> 
> type=AVC msg=audit(1545153126.899:210): avc:  denied  { search } for pid=8448 comm="lightdm" name="faillock" dev="tmpfs" ino=39318 scontext=system_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545153131.090:214): avc:  denied  { write } for pid=8448 comm="lightdm" name="faillock" dev="tmpfs" ino=39318 scontext=system_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545153131.090:214): avc:  denied  { add_name } for pid=8448 comm="lightdm" name="dsugar" scontext=system_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545153131.090:214): avc:  denied  { create } for pid=8448 comm="lightdm" name="dsugar" scontext=system_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=file permissive=1
> type=AVC msg=audit(1545153131.091:215): avc:  denied  { setattr } for pid=8448 comm="lightdm" name="dsugar" dev="tmpfs" ino=87599 scontext=system_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=file permissive=1
> 
> type=AVC msg=audit(1545167205.531:626): avc:  denied  { search } for pid=8264 comm="sudo" name="faillock" dev="tmpfs" ino=35405 scontext=sysadm_u:sysadm_r:cleaner_applyconfig_sudo_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545167205.531:627): avc:  denied  { write } for pid=8264 comm="sudo" name="faillock" dev="tmpfs" ino=35405 scontext=sysadm_u:sysadm_r:cleaner_applyconfig_sudo_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545167205.531:627): avc:  denied  { add_name } for pid=8264 comm="sudo" name="root" scontext=sysadm_u:sysadm_r:cleaner_applyconfig_sudo_t:s0-s0:c0.c1023 tcontext=system_u:object_r:faillog_t:s0 tclass=dir permissive=1
> type=AVC msg=audit(1545167205.531:627): avc:  denied  { create } for pid=8264 comm="sudo" name="root" scontext=sysadm_u:sysadm_r:cleaner_applyconfig_sudo_t:s0-s0:c0.c1023 tcontext=sysadm_u:object_r:faillog_t:s0 tclass=file permissive=1
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/admin/sudo.if       |  2 +-
>   policy/modules/services/xserver.te |  1 -
>   policy/modules/system/authlogin.if | 38 ++++++++++++++++++++++++++++++
>   3 files changed, 39 insertions(+), 2 deletions(-)
> 
> diff --git a/policy/modules/admin/sudo.if b/policy/modules/admin/sudo.if
> index 01f408ef..1c1fbe7b 100644
> --- a/policy/modules/admin/sudo.if
> +++ b/policy/modules/admin/sudo.if
> @@ -116,8 +116,8 @@ template(`sudo_role_template',`
>   	auth_run_chk_passwd($1_sudo_t, $2)
>   	# sudo stores a token in the pam_pid directory
>   	auth_manage_pam_pid($1_sudo_t)
> +	auth_use_pam($1_sudo_t)
>   	auth_pid_filetrans_pam_var_run($1_sudo_t, dir, "sudo")
> -	auth_use_nsswitch($1_sudo_t)
>   
>   	init_rw_utmp($1_sudo_t)
>   
> diff --git a/policy/modules/services/xserver.te b/policy/modules/services/xserver.te
> index c7714d3e..edac2833 100644
> --- a/policy/modules/services/xserver.te
> +++ b/policy/modules/services/xserver.te
> @@ -484,7 +484,6 @@ term_setattr_unallocated_ttys(xdm_t)
>   auth_domtrans_pam_console(xdm_t)
>   auth_manage_pam_pid(xdm_t)
>   auth_manage_pam_console_data(xdm_t)
> -auth_rw_faillog(xdm_t)
>   auth_write_login_records(xdm_t)
>   
>   # Run telinit->init to shutdown.
> diff --git a/policy/modules/system/authlogin.if b/policy/modules/system/authlogin.if
> index 9b5e0fe0..0153ab07 100644
> --- a/policy/modules/system/authlogin.if
> +++ b/policy/modules/system/authlogin.if
> @@ -47,6 +47,7 @@ interface(`auth_use_pam',`
>   	# for encrypted homedir
>   	dev_read_sysfs($1)
>   
> +	auth_create_faillog_files($1)
>   	auth_domtrans_chk_passwd($1)
>   	auth_domtrans_upd_passwd($1)
>   	auth_dontaudit_read_shadow($1)
> @@ -54,6 +55,7 @@ interface(`auth_use_pam',`
>   	auth_append_login_records($1)
>   	auth_rw_lastlog($1)
>   	auth_rw_faillog($1)
> +	auth_setattr_faillog_files($1)
>   	auth_exec_pam($1)
>   	auth_use_nsswitch($1)
>   
> @@ -744,6 +746,24 @@ interface(`auth_append_faillog',`
>   	allow $1 faillog_t:file append_file_perms;
>   ')
>   
> +########################################
> +## <summary>
> +##	Create fail log lock (in /run/faillock).
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`auth_create_faillog_files',`
> +	gen_require(`
> +		type faillog_t;
> +	')
> +
> +	create_files_pattern($1, faillog_t, faillog_t)
> +')
> +
>   ########################################
>   ## <summary>
>   ##	Read and write the login failure log.
> @@ -782,6 +802,24 @@ interface(`auth_manage_faillog',`
>   	logging_rw_generic_log_dirs($1)
>   ')
>   
> +########################################
> +## <summary>
> +##	Setattr the login failure logs.
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`auth_setattr_faillog_files',`
> +	gen_require(`
> +		type faillog_t;
> +	')
> +
> +	setattr_files_pattern($1, faillog_t, faillog_t)
> +')
> +
>   #######################################
>   ## <summary>
>   ##	Read the last logins log.
> 

Merged.

-- 
Chris PeBenito