Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353FAC43387 for ; Fri, 11 Jan 2019 00:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7E7120872 for ; Fri, 11 Jan 2019 00:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=coker.com.au header.i=@coker.com.au header.b="3NoSsPaY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbfAKA2M (ORCPT ); Thu, 10 Jan 2019 19:28:12 -0500 Received: from smtp.sws.net.au ([46.4.88.250]:50954 "EHLO smtp.sws.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbfAKA2M (ORCPT ); Thu, 10 Jan 2019 19:28:12 -0500 Received: from liv.localnet (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id 919C9EDAA; Fri, 11 Jan 2019 11:28:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1547166490; bh=MWtHa5rOnc0Qxvo57D9z9lBnX6UQrepVbVZEtscapRU=; l=887; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=3NoSsPaY26MtljUYl0ariiWPJ56o9C2V5E5LLH94WW051wM/0TuWVzP4zw3QawaAs CDsAmVNW4ULE7B9JaTXMVDu3iKhWyU/00mQM8wpWX7oYA5qRSUlY6h/2wJvQ2LpD0S DyNchpfI8n2N4ZheEBS6gGHcS7hpkC8P4sM99QTI= From: Russell Coker To: Nicolas Iooss Cc: Chris PeBenito , selinux-refpolicy@vger.kernel.org Subject: Re: [PATCH] /run/systemd/units/ links Date: Fri, 11 Jan 2019 11:28:04 +1100 Message-ID: <4532148.u2APPhryqx@liv> In-Reply-To: References: <20190108114151.GA416@xev> <60dbf2ed-45e9-a94a-f37a-925a7c410aee@ieee.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On Friday, 11 January 2019 10:08:22 AM AEDT Nicolas Iooss wrote: > > I guess this is a race between patches. Should be named > > init_read_pid_symlinks. Same feedback as GitHub PR > > https://github.com/SELinuxProject/refpolicy/pull/17 > > I like "init_read_runtime_symlinks" more than "init_read_pid_symlinks" > so I have uploaded my Pull Request. If your prefer the second name, I > can change it again. > Compared to this patch, my PR does not use files_search_pids() but > directly read_lnk_files_pattern() like some other interfaces. I have > no strong preferences regarding this. I'm really not bothered by the name. Whatever gets it included in git the fastest is good for me. Also I'd really like to see a new upstream release before the end of the month if convenient. -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/