Subject: Re: [PATCH] /run/systemd/units/ links
To:     Russell Coker <russell@coker.com.au>,
        Nicolas Iooss <nicolas.iooss@m4x.org>
Cc:     selinux-refpolicy@vger.kernel.org
References: <20190108114151.GA416@xev>
 <60dbf2ed-45e9-a94a-f37a-925a7c410aee@ieee.org>
 <CAJfZ7==bZS49VWqEy8KmPoKtR+msqC9VV876hHuRmUJLRDxLFw@mail.gmail.com>
 <4532148.u2APPhryqx@liv>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <dedf3ce8-4e9f-2313-6799-bbc9dc3a8124@ieee.org>
Date:   Thu, 10 Jan 2019 20:26:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <4532148.u2APPhryqx@liv>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/10/19 7:28 PM, Russell Coker wrote:
> On Friday, 11 January 2019 10:08:22 AM AEDT Nicolas Iooss wrote:
>>> I guess this is a race between patches.  Should be named
>>> init_read_pid_symlinks.  Same feedback as GitHub PR
>>> https://github.com/SELinuxProject/refpolicy/pull/17
>>
>> I like "init_read_runtime_symlinks" more than "init_read_pid_symlinks"
>> so I have uploaded my Pull Request. If your prefer the second name, I
>> can change it again.
>> Compared to this patch, my PR does not use files_search_pids() but
>> directly read_lnk_files_pattern() like some other interfaces. I have
>> no strong preferences regarding this.
> 
> I'm really not bothered by the name.  Whatever gets it included in git the
> fastest is good for me.
> 
> Also I'd really like to see a new upstream release before the end of the month
> if convenient.

I've merged the PR, though this means the init_*_pid_*() interfaces will 
need to be deprecated and replaced, for consistency.

-- 
Chris PeBenito