Subject: Re: [PATCH] more tiny stuff
To:     Russell Coker <russell@coker.com.au>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20190119120444.GA1199@xev>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <e090bca1-b6c4-7d5d-549f-4efc5e385172@ieee.org>
Date:   Sun, 20 Jan 2019 16:22:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190119120444.GA1199@xev>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/19/19 7:04 AM, Russell Coker wrote:
> I think the old timesync labelling wasn't working anyway due to -- for a
> directory name.
> 
> A couple of patches for devicekit calling dmidecode (this is part of replacing
> some kmem access that was discussed on this list and rejected as a misfeature
> in Debian DMI related code ages ago).
> 
> The rest should be obvious.
> 
> Index: refpolicy-2.20180701/policy/modules/services/ntp.fc
> ===================================================================
> --- refpolicy-2.20180701.orig/policy/modules/services/ntp.fc
> +++ refpolicy-2.20180701/policy/modules/services/ntp.fc
> @@ -32,7 +32,7 @@
>   /var/lib/ntp(/.*)?				gen_context(system_u:object_r:ntp_drift_t,s0)
>   /var/lib/sntp-kod(/.*)?				gen_context(system_u:object_r:ntp_drift_t,s0)
>   /var/lib/systemd/clock			--	gen_context(system_u:object_r:ntp_drift_t,s0)
> -/var/lib/private/systemd/timesync(/.*)? --	gen_context(system_u:object_r:ntp_drift_t,s0)
> +/var/lib/systemd/timesync(/.*)?			gen_context(system_u:object_r:ntp_drift_t,s0)
>   
>   /var/lock/ntpdate                       --      gen_context(system_u:object_r:ntpd_lock_t,s0)
>   
> Index: refpolicy-2.20180701/policy/modules/admin/dmidecode.te
> ===================================================================
> --- refpolicy-2.20180701.orig/policy/modules/admin/dmidecode.te
> +++ refpolicy-2.20180701/policy/modules/admin/dmidecode.te
> @@ -32,3 +32,9 @@ mls_file_read_all_levels(dmidecode_t)
>   locallogin_use_fds(dmidecode_t)
>   
>   userdom_use_inherited_user_terminals(dmidecode_t)
> +
> +ifdef(`init_systemd',`
> +	# inherits /dev/null and a socket from devicekit_disk_t
> +	init_use_fds(dmidecode_t)
> +	init_rw_inherited_stream_socket(dmidecode_t)
> +')
> Index: refpolicy-2.20180701/policy/modules/services/devicekit.te
> ===================================================================
> --- refpolicy-2.20180701.orig/policy/modules/services/devicekit.te
> +++ refpolicy-2.20180701/policy/modules/services/devicekit.te
> @@ -177,6 +177,10 @@ optional_policy(`
>   ')
>   
>   optional_policy(`
> +	dmidecode_domtrans(devicekit_disk_t)
> +')
> +
> +optional_policy(`
>   	fstools_domtrans(devicekit_disk_t)
>   ')
>   
> Index: refpolicy-2.20180701/policy/modules/services/xserver.te
> ===================================================================
> --- refpolicy-2.20180701.orig/policy/modules/services/xserver.te
> +++ refpolicy-2.20180701/policy/modules/services/xserver.te
> @@ -291,6 +291,8 @@ kernel_request_load_module(xauth_t)
>   
>   domain_use_interactive_fds(xauth_t)
>   
> +dev_read_sysfs(xauth_t)
> +
>   files_read_etc_files(xauth_t)
>   files_search_pids(xauth_t)
>   
> Index: refpolicy-2.20180701/policy/modules/system/unconfined.te
> ===================================================================
> --- refpolicy-2.20180701.orig/policy/modules/system/unconfined.te
> +++ refpolicy-2.20180701/policy/modules/system/unconfined.te
> @@ -59,6 +59,9 @@ ifdef(`direct_sysadm_daemon',`
>   ')
>   
>   ifdef(`init_systemd',`
> +	# for systemd-analyze
> +	init_service_status(unconfined_t)
> +
>   	optional_policy(`
>   		systemd_dbus_chat_resolved(unconfined_t)
>   	')

Merged.

-- 
Chris PeBenito