Subject: Re: [PATCH] Add hostapd service module
To:     Alexander Miroshnichenko <alex@millerson.name>,
        selinux-refpolicy@vger.kernel.org
References: <20190129190152.10890-1-alex@millerson.name>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <f521b94d-49bf-0caf-2d1c-0960710d7680@ieee.org>
Date:   Tue, 29 Jan 2019 18:42:44 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190129190152.10890-1-alex@millerson.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/29/19 2:01 PM, Alexander Miroshnichenko wrote:
> Add a SELinux Reference Policy module for the hostapd
> IEEE 802.11 wireless LAN Host AP daemon.
> ---
>   policy/modules/services/hostapd.fc |  7 ++++
>   policy/modules/services/hostapd.if |  1 +
>   policy/modules/services/hostapd.te | 56 ++++++++++++++++++++++++++++++
>   3 files changed, 64 insertions(+)
>   create mode 100644 policy/modules/services/hostapd.fc
>   create mode 100644 policy/modules/services/hostapd.if
>   create mode 100644 policy/modules/services/hostapd.te
> 
> diff --git a/policy/modules/services/hostapd.fc b/policy/modules/services/hostapd.fc
> new file mode 100644
> index 00000000..83583a77
> --- /dev/null
> +++ b/policy/modules/services/hostapd.fc
> @@ -0,0 +1,7 @@
> +/usr/sbin/hostapd               --      gen_context(system_u:object_r:hostapd_exec_t,s0)
> +
> +/var/run/hostapd(/.*)?          gen_context(system_u:object_r:hostapd_var_run_t,s0)
> +
> +/etc/hostapd(/.*)?          gen_context(system_u:object_r:hostapd_conf_t,s0)
> +
> +/run/hostapd.pid                --      gen_context(system_u:object_r:hostapd_var_run_t,s0)
> diff --git a/policy/modules/services/hostapd.if b/policy/modules/services/hostapd.if
> new file mode 100644
> index 00000000..fce874d2
> --- /dev/null
> +++ b/policy/modules/services/hostapd.if
> @@ -0,0 +1 @@
> +## <summary>IEEE 802.11 wireless LAN Host AP daemon.</summary>
> diff --git a/policy/modules/services/hostapd.te b/policy/modules/services/hostapd.te
> new file mode 100644
> index 00000000..2db1e7de
> --- /dev/null
> +++ b/policy/modules/services/hostapd.te
> @@ -0,0 +1,56 @@
> +policy_module(hostapd, 1.0.0)
> +
> +########################################
> +#
> +# Declarations
> +#
> +
> +type hostapd_t;
> +type hostapd_exec_t;
> +init_daemon_domain(hostapd_t, hostapd_exec_t)
> +
> +type hostapd_var_run_t;
> +files_pid_file(hostapd_var_run_t)
> +
> +type hostapd_conf_t;
> +files_type(hostapd_conf_t)
> +
> +########################################
> +#
> +# hostapd local policy
> +#
> +
> +allow hostapd_t self:capability { fsetid chown net_admin net_raw dac_read_search dac_override };
> +allow hostapd_t self:fifo_file rw_fifo_file_perms;
> +allow hostapd_t self:unix_stream_socket create_stream_socket_perms;
> +allow hostapd_t self:netlink_socket create_socket_perms;
> +allow hostapd_t self:netlink_generic_socket create_socket_perms;
> +allow hostapd_t self:netlink_route_socket create_netlink_socket_perms;
> +allow hostapd_t self:packet_socket create_socket_perms;
> +
> +manage_dirs_pattern(hostapd_t, hostapd_var_run_t, hostapd_var_run_t)
> +manage_files_pattern(hostapd_t, hostapd_var_run_t, hostapd_var_run_t)
> +manage_lnk_files_pattern(hostapd_t, hostapd_var_run_t, hostapd_var_run_t)
> +manage_sock_files_pattern(hostapd_t, hostapd_var_run_t, hostapd_var_run_t)
> +files_pid_filetrans(hostapd_t, hostapd_var_run_t, { dir file lnk_file sock_file })
> +
> +read_files_pattern(hostapd_t, hostapd_conf_t, hostapd_conf_t)
> +
> +kernel_read_system_state(hostapd_t)
> +kernel_read_network_state(hostapd_t)
> +kernel_request_load_module(hostapd_t)
> +kernel_rw_net_sysctls(hostapd_t)
> +dev_rw_sysfs(hostapd_t)
> +
> +dev_read_rand(hostapd_t)
> +dev_read_urand(hostapd_t)
> +dev_read_sysfs(hostapd_t)
> +dev_rw_wireless(hostapd_t)
> +
> +domain_use_interactive_fds(hostapd_t)
> +
> +auth_use_nsswitch(hostapd_t)
> +
> +logging_send_syslog_msg(hostapd_t)
> +
> +miscfiles_read_localization(hostapd_t)

Merged.

-- 
Chris PeBenito