Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76472C282C4 for ; Sat, 9 Feb 2019 10:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E42221773 for ; Sat, 9 Feb 2019 10:26:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=coker.com.au header.i=@coker.com.au header.b="Zyr+7PZg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfBIK0E (ORCPT ); Sat, 9 Feb 2019 05:26:04 -0500 Received: from smtp.sws.net.au ([46.4.88.250]:40486 "EHLO smtp.sws.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726724AbfBIK0E (ORCPT ); Sat, 9 Feb 2019 05:26:04 -0500 Received: from liv.localnet (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id A827DED8E for ; Sat, 9 Feb 2019 21:25:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1549707960; bh=kEUEfZrtkhrFgd0zsjxBcNuwAkKtcUhh4vJWPUOLThk=; l=460; h=From:To:Subject:Date:From; b=Zyr+7PZgwbSdYfqkkz8ml6jiTV6/ALclqEQJKLGj/ldSECGQpphSJK0j0Cubni8zx px9BGuakQXz4PnT1/Tfgh7N3AMJQbVO9+9nBW8rVU5xukX+WNvnhFEwLwIDSspj8oe XcdHwkUkCvkAPbB8KVQ6Y8ZcX0gO+nxvGCdZ6tUU= From: Russell Coker To: "selinux-refpolicy@vger.kernel.org" Subject: read_file_perms vs mmap_read_file_perms Date: Sat, 09 Feb 2019 21:25:47 +1100 Message-ID: <1938152.zeI3LBqMHI@liv> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org define(`read_file_perms',`{ getattr open read lock ioctl }') define(`mmap_read_file_perms',`{ getattr open map read ioctl }') I think that the general expectation would be that mmap_read_file_perms is a superset of read_file_perms. Is there any reason why mmap_read_file_perms doesn't include lock permission? If not I think we should add it to avoid surprises. -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/