Subject: Re: [PATCH] Separate domain for systemd-modules-load
To:     "Sugar, David" <dsugar@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20190207211422.10855-1-dsugar@tresys.com>
 <20190207211422.10855-2-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <7d900ab7-d237-d75c-ee98-232531ecf82f@ieee.org>
Date:   Sat, 9 Feb 2019 09:07:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190207211422.10855-2-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 2/7/19 4:15 PM, Sugar, David wrote:
> systemd-modules-load is used to pre-load kernal modules as the system comes up.
> It was running initc_t which didn't have permissions to actually load kernel
> modules.  This change sets up a new domain for this service and grants permission
> necessary to load kernel modules.
> 
> Feb 05 03:38:20 4c4c4544-0052-5410-8043-b1c04f503232 kernel: type=1400 audit(1549337898.886:10): avc:  denied  { read } for  pid=4257 comm="systemd-modules" name="fuse.ko.xz" dev="dm-1" ino=2390271 scontext=system_u:system_r:initrc_t:s0 tcontext=system_u:object_r:modules_object_t:s0 tclass=file permissive=1
> Feb 05 03:38:20 4c4c4544-0052-5410-8043-b1c04f503232 kernel: type=1400 audit(1549337898.886:11): avc:  denied  { open } for  pid=4257 comm="systemd-modules" path="/usr/lib/modules/3.10.0-957.1.3.el7.x86_64/kernel/fs/fuse/fuse.ko.xz" dev="dm-1" ino=2390271 scontext=system_u:system_r:initrc_t:s0 tcontext=system_u:object_r:modules_object_t:s0 tclass=file permissive=1
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/system/systemd.fc |  1 +
>   policy/modules/system/systemd.te | 15 +++++++++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/policy/modules/system/systemd.fc b/policy/modules/system/systemd.fc
> index 22cfe4e6..3b0302b6 100644
> --- a/policy/modules/system/systemd.fc
> +++ b/policy/modules/system/systemd.fc
> @@ -26,6 +26,7 @@
>   /usr/lib/systemd/systemd-localed	--	gen_context(system_u:object_r:systemd_locale_exec_t,s0)
>   /usr/lib/systemd/systemd-logind		--	gen_context(system_u:object_r:systemd_logind_exec_t,s0)
>   /usr/lib/systemd/systemd-machined	--	gen_context(system_u:object_r:systemd_machined_exec_t,s0)
> +/usr/lib/systemd/systemd-modules-load	--	gen_context(system_u:object_r:systemd_modules_load_exec_t,s0)
>   /usr/lib/systemd/systemd-networkd	--	gen_context(system_u:object_r:systemd_networkd_exec_t,s0)
>   /usr/lib/systemd/systemd-resolved	--	gen_context(system_u:object_r:systemd_resolved_exec_t,s0)
>   /usr/lib/systemd/systemd-rfkill		--	gen_context(system_u:object_r:systemd_rfkill_exec_t,s0)
> diff --git a/policy/modules/system/systemd.te b/policy/modules/system/systemd.te
> index a6f09dfd..64e36c66 100644
> --- a/policy/modules/system/systemd.te
> +++ b/policy/modules/system/systemd.te
> @@ -119,6 +119,10 @@ type systemd_machined_var_run_t;
>   files_pid_file(systemd_machined_var_run_t)
>   init_daemon_pid_file(systemd_machined_var_run_t, dir, "machines")
>   
> +type systemd_modules_load_t;
> +type systemd_modules_load_exec_t;
> +init_daemon_domain(systemd_modules_load_t, systemd_modules_load_exec_t)
> +
>   type systemd_networkd_t;
>   type systemd_networkd_exec_t;
>   init_system_domain(systemd_networkd_t, systemd_networkd_exec_t)
> @@ -606,6 +610,17 @@ optional_policy(`
>   	dbus_system_bus_client(systemd_machined_t)
>   ')
>   
> +########################################
> +#
> +# modules-load local policy
> +#
> +
> +files_load_kernel_modules(systemd_modules_load_t)
> +files_read_etc_files(systemd_modules_load_t)
> +
> +init_read_state(systemd_modules_load_t)
> +init_search_run(systemd_modules_load_t)
> +
>   ########################################
>   #
>   # networkd local policy

Merged.

-- 
Chris PeBenito