From:   Dominick Grift <dac.override@gmail.com>
To:     "Sugar\, David" <dsugar@tresys.com>
Cc:     "selinux-refpolicy\@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] Allow AIDE to sendto kernel datagram socket
References: <20190225233708.15319-1-dsugar@tresys.com>
        <20190225233708.15319-4-dsugar@tresys.com> <87pnrf9h34.fsf@gmail.com>
        <eeedb7d7-e2e6-6da2-7e2d-2e55f3f4f0cf@tresys.com>
Date:   Tue, 26 Feb 2019 13:32:55 +0100
In-Reply-To: <eeedb7d7-e2e6-6da2-7e2d-2e55f3f4f0cf@tresys.com> (David Sugar's
        message of "Tue, 26 Feb 2019 12:28:10 +0000")
Message-ID: <87lg22afwo.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

"Sugar, David" <dsugar@tresys.com> writes:

> On 2/26/19 1:52 AM, Dominick Grift wrote:
>> "Sugar, David" <dsugar@tresys.com> writes:
>> 
>>> type=AVC msg=audit(1550799594.394:205): avc: denied { sendto } for
>>> pid=7182 comm="aide" path="/dev/log"
>>> scontext=system_u:system_r:aide_t:s0
>>> tcontext=system_u:system_r:kernel_t:s0 tclass=unix_dgram_socket
>>> permissive=1
>> 
>> Is this not part of logging_send_syslog_msg()? It should be AFAIK.
>> 
> Looking at logging.if I don't see any kernel interfaces used.  So, no it 
> isn't in there currently.  Based on how logging seems to now work with 
> journald it might be a good idea to move these individual uses and just 
> rely on the loggin_send_syslog_msg interface to take care of it.
>

I see. I will let other decides on how to deal with this. In dssp2 i
have:

       (call sys.unix_dgram_socket_sendto (client_subj_type_attribute))
       (call sys.unix_stream_socket_connectto (client_subj_type_attribute))

Not sure why i also added the "unix_stream_socket connectto;", but i suppose
there was a need for it at some point at least.

> I'm happy to make this change if that is desired.
>
>>>
>>> Signed-off-by: Dave Sugar <dsugar@tresys.com>
>>> ---
>>>   policy/modules/admin/aide.te | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/policy/modules/admin/aide.te b/policy/modules/admin/aide.te
>>> index 9d3c19ce..6297b60e 100644
>>> --- a/policy/modules/admin/aide.te
>>> +++ b/policy/modules/admin/aide.te
>>> @@ -35,6 +35,8 @@ logging_log_filetrans(aide_t, aide_log_t, file)
>>>   files_read_all_files(aide_t)
>>>   files_read_all_symlinks(aide_t)
>>>   
>>> +kernel_dgram_send(aide_t)
>>> +
>>>   logging_send_audit_msgs(aide_t)
>>>   logging_send_syslog_msg(aide_t)
>> 

-- 
Key fingerprint = 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=get&search=0x3B6C5F1D2C7B6B02
Dominick Grift