Subject: Re: [PATCH] Add interface to allow relabeling of iso 9660
 filesystems.
To:     "Sugar, David" <dsugar@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20190305223209.18922-1-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <49941fbb-0b1e-0a67-3c48-7f777daad37d@ieee.org>
Date:   Thu, 7 Mar 2019 18:55:46 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190305223209.18922-1-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 3/5/19 5:32 PM, Sugar, David wrote:
> I have a case where I'm labeling media with my own types to control
> access.  But that is requiring that I relabel from iso9660_t to my
> own type.  This interface allows that relabel.
> 
> type=AVC msg=audit(1551621984.372:919): avc:  denied  { relabelfrom } for  pid=9717 comm="mount" scontext=staff_u:staff_r:mymedia_sudo_t:s0-s0:c0.c1023 tcontext=system_u:object_r:iso9660_t:s0 tclass=filesystem permissive=0
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/kernel/filesystem.if | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/policy/modules/kernel/filesystem.if b/policy/modules/kernel/filesystem.if
> index 048b9d65..a22cb6ba 100644
> --- a/policy/modules/kernel/filesystem.if
> +++ b/policy/modules/kernel/filesystem.if
> @@ -2505,6 +2505,25 @@ interface(`fs_remount_iso9660_fs',`
>   	allow $1 iso9660_t:filesystem remount;
>   ')
>   
> +########################################
> +## <summary>
> +##	Allow changing of the label of a
> +##	filesystem with iso9660 type
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`fs_relabelfrom_iso9660_fs',`
> +	gen_require(`
> +		type iso9660_t;
> +	')
> +
> +	allow $1 iso9660_t:filesystem relabelfrom;
> +')
> +
>   ########################################
>   ## <summary>
>   ##	Unmount an iso9660 filesystem, which

Merged.

-- 
Chris PeBenito