Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524CCC43381 for ; Tue, 26 Mar 2019 22:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 054362075D for ; Tue, 26 Mar 2019 22:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=tresys.onmicrosoft.com header.i=@tresys.onmicrosoft.com header.b="oHFU9wlV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731630AbfCZWAb (ORCPT ); Tue, 26 Mar 2019 18:00:31 -0400 Received: from mail-eopbgr740100.outbound.protection.outlook.com ([40.107.74.100]:52994 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731621AbfCZWAb (ORCPT ); Tue, 26 Mar 2019 18:00:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tresys.onmicrosoft.com; s=selector1-tresys-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CvzSvCeE/KtOikCgvnHn2U6DsA38dmG0g7G5DNTQL8=; b=oHFU9wlVc595WvbzAv5rPUmALlzdEeg7xuzvH4eqtldi41W1DrZfDT8an+tvaOABDiA5G4ezOdBZJImVT7OoDmH/pcKLC25/4K5i4ANt9sX0UpwE64MpD+pFWeml/6nRXIXbj3ah7zrisj0XNs9vSRx6RWBsqXLRKTV9+aqW/9Q= Received: from BN6PR15MB1507.namprd15.prod.outlook.com (10.172.151.147) by BN6PR15MB1684.namprd15.prod.outlook.com (10.175.131.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Tue, 26 Mar 2019 22:00:28 +0000 Received: from BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::ec41:1dc7:5fd4:a07a]) by BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::ec41:1dc7:5fd4:a07a%8]) with mapi id 15.20.1730.019; Tue, 26 Mar 2019 22:00:27 +0000 From: "Sugar, David" To: "selinux-refpolicy@vger.kernel.org" Subject: [PATCH 4/4-v2] Allow ntpd to read unit files Thread-Topic: [PATCH 4/4-v2] Allow ntpd to read unit files Thread-Index: AQHU5B9SKYtl9r8IWEiZqmg6sY4XnQ== Date: Tue, 26 Mar 2019 22:00:27 +0000 Message-ID: <20190326220014.31256-1-dsugar@tresys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [96.244.17.66] x-clientproxiedby: MN2PR12CA0009.namprd12.prod.outlook.com (2603:10b6:208:a8::22) To BN6PR15MB1507.namprd15.prod.outlook.com (2603:10b6:404:c6::19) authentication-results: spf=none (sender IP is ) smtp.mailfrom=dsugar@tresys.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 966eb27f-c239-4ad1-87de-08d6b236748a x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BN6PR15MB1684; x-ms-traffictypediagnostic: BN6PR15MB1684: x-microsoft-antispam-prvs: x-forefront-prvs: 09888BC01D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39830400003)(366004)(346002)(396003)(136003)(189003)(199004)(86362001)(5640700003)(81156014)(102836004)(53936002)(2501003)(52116002)(6436002)(8936002)(1076003)(21490400003)(6486002)(6512007)(8676002)(2351001)(106356001)(105586002)(99286004)(2906002)(5660300002)(50226002)(71190400001)(6506007)(71200400001)(81166006)(386003)(6916009)(508600001)(26005)(6116002)(186003)(66066001)(256004)(14444005)(14454004)(25786009)(68736007)(2616005)(97736004)(476003)(486006)(305945005)(316002)(7736002)(36756003)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1684;H:BN6PR15MB1507.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: tresys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: XMQkHXQzujdkUY/hfpGqIWbHbuj4jvczoYcYyTE1f5lJIQDPN2l+BYxQN/B0CbYkCS+KT+yUM5zbL537xQfukqR0hvg5DYx7lq9Dumd6x5txs40Cb7NJHvA869jS83HGbBped2zTUgmgDl3uMuZ7gxkgdwVmhfcC8olXgHQkVQzkk6TwlYPAWXZfNRi59MoALuyDOPnlzyfmeSF/c6oFXyV4PLAxGR6ApqaiiKcwYbBxc3r5Z/eIYES1ejAWxZMN0I9UYpG4WN6ZJjmYIwp16YtAESYaEdfgZ5+WATpkoPp1mbUD5yqcD4+kFHRGiuovoUL1QnHro8piyWRpY27+8XJ82IF5P4DUB6CoEtekbQAY9QetKhhMdOrLh0kwya47Z+oeAqzUbk3szAesVKNzKc0sRf3EtZ00491CEOAXmnY= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: tresys.com X-MS-Exchange-CrossTenant-Network-Message-Id: 966eb27f-c239-4ad1-87de-08d6b236748a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 22:00:27.6941 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a0d45667-6c07-4e88-868f-4ac9af95c7ed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1684 Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org Adding missing documenation (sorry about that). type=3DAVC msg=3Daudit(1553013917.359:9935): avc: denied { read } for pi= d=3D16326 comm=3D"systemd-timedat" name=3D"50-chronyd.list" dev=3D"dm-1" in= o=3D4870675 scontext=3Dsystem_u:system_r:ntpd_t:s0 tcontext=3Dsystem_u:obje= ct_r:ntpd_unit_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1553013917.359:9935): avc: denied { open } for pi= d=3D16326 comm=3D"systemd-timedat" path=3D"/usr/lib/systemd/ntp-units.d/50-= chronyd.list" dev=3D"dm-1" ino=3D4870675 scontext=3Dsystem_u:system_r:ntpd_= t:s0 tcontext=3Dsystem_u:object_r:ntpd_unit_t:s0 tclass=3Dfile permissive= =3D1 type=3DAVC msg=3Daudit(1553013917.359:9936): avc: denied { getattr } for = pid=3D16326 comm=3D"systemd-timedat" path=3D"/usr/lib/systemd/ntp-units.d/= 50-chronyd.list" dev=3D"dm-1" ino=3D4870675 scontext=3Dsystem_u:system_r:nt= pd_t:s0 tcontext=3Dsystem_u:object_r:ntpd_unit_t:s0 tclass=3Dfile permissiv= e=3D1 type=3DAVC msg=3Daudit(1553013821.622:9902): avc: denied { getattr } for = pid=3D16281 comm=3D"systemd-timedat" path=3D"/usr/lib/systemd/ntp-units.d"= dev=3D"dm-1" ino=3D4700094 scontext=3Dsystem_u:system_r:ntpd_t:s0 tcontext= =3Dsystem_u:object_r:systemd_unit_t:s0 tclass=3Ddir permissive=3D1 type=3DAVC msg=3Daudit(1553013821.622:9903): avc: denied { read } for pi= d=3D16281 comm=3D"systemd-timedat" name=3D"ntp-units.d" dev=3D"dm-1" ino=3D= 4700094 scontext=3Dsystem_u:system_r:ntpd_t:s0 tcontext=3Dsystem_u:object_r= :systemd_unit_t:s0 tclass=3Ddir permissive=3D1 type=3DAVC msg=3Daudit(1553013821.622:9903): avc: denied { open } for pi= d=3D16281 comm=3D"systemd-timedat" path=3D"/usr/lib/systemd/ntp-units.d" de= v=3D"dm-1" ino=3D4700094 scontext=3Dsystem_u:system_r:ntpd_t:s0 tcontext=3D= system_u:object_r:systemd_unit_t:s0 tclass=3Ddir permissive=3D1 Signed-off-by: Dave Sugar --- policy/modules/services/ntp.te | 3 +++ policy/modules/system/init.if | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/policy/modules/services/ntp.te b/policy/modules/services/ntp.t= e index a95bf21d..982d6a4c 100644 --- a/policy/modules/services/ntp.te +++ b/policy/modules/services/ntp.te @@ -138,10 +138,13 @@ userdom_dontaudit_use_unpriv_user_fds(ntpd_t) userdom_list_user_home_dirs(ntpd_t) =20 ifdef(`init_systemd',` + allow ntpd_t ntpd_unit_t:file read_file_perms; + dbus_system_bus_client(ntpd_t) dbus_connect_system_bus(ntpd_t) init_dbus_chat(ntpd_t) init_get_system_status(ntpd_t) + init_list_unit_dirs(ntpd_t) # for /var/lib/systemd/timesync init_read_var_lib_links(ntpd_t) allow ntpd_t self:capability { fowner setpcap }; diff --git a/policy/modules/system/init.if b/policy/modules/system/init.if index 2a17910e..be2c0a70 100644 --- a/policy/modules/system/init.if +++ b/policy/modules/system/init.if @@ -2960,6 +2960,26 @@ interface(`init_search_units',` fs_search_tmpfs($1) ') =20 +###################################### +## +## List systemd unit dirs. +## +## +## +## Domain allowed access. +## +## +# +interface(`init_list_unit_dirs',` + gen_require(` + type systemd_unit_t; + ') + + allow $1 systemd_unit_t:dir list_dir_perms; + + init_search_units($1) +') + ######################################## ## ## Read systemd unit links --=20 2.20.1