Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] add lldpd policy
To:     Alexander Miroshnichenko <alex@millerson.name>,
        selinux-refpolicy@vger.kernel.org
References: <20190610142004.2719-1-alex@millerson.name>
 <749388e0-6da1-4b06-c62c-35302a5aba78@ieee.org>
 <20190615175859.GA2818@brutus.lan>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <3d0d13b8-3090-558e-23b6-7edaeeff3f92@ieee.org>
Date:   Sat, 15 Jun 2019 15:24:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190615175859.GA2818@brutus.lan>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 6/15/19 1:58 PM, Dominick Grift wrote:
> On Sat, Jun 15, 2019 at 12:08:16PM -0400, Chris PeBenito wrote:
>> On 6/10/19 10:20 AM, Alexander Miroshnichenko wrote:

>>> +allow lldpd_t self:process { fork signal_perms };
>>> +allow lldpd_t self:fifo_file rw_fifo_file_perms;
>>> +allow lldpd_t self:unix_stream_socket { accept listen };
>>
>> These perms should probably be create_stream_socket_perms.
> 
> the other permissions are already provided with logging_send_syslog_msg() so would be reduntant

This is true.  However,the syslog socket is not the only socket in use. 
Since it also listens on its own stream socket, the 
create_stream_socket_perms more clearly shows the intent.


-- 
Chris PeBenito