Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Jun 2019 16:46:39 +0200
From:   Dominick Grift <dac.override@gmail.com>
To:     Alexander Miroshnichenko <alex@millerson.name>
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ssh: Add ssh_exec_keygen interface
Message-ID: <20190620144639.GB2647@brutus.lan>
Mail-Followup-To: Alexander Miroshnichenko <alex@millerson.name>,
        selinux-refpolicy@vger.kernel.org
References: <20190620144138.15172-1-alex@millerson.name>
 <20190620144138.15172-2-alex@millerson.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="oLBj+sq0vYjzfsbl"
Content-Disposition: inline
In-Reply-To: <20190620144138.15172-2-alex@millerson.name>
User-Agent: Every email client sucks, this one just sucks less.
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk


--oLBj+sq0vYjzfsbl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 20, 2019 at 05:41:37PM +0300, Alexander Miroshnichenko wrote:
> Signed-off-by: Alexander Miroshnichenko <alex@millerson.name>
> ---
>  policy/modules/services/ssh.if | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>=20
> diff --git a/policy/modules/services/ssh.if b/policy/modules/services/ssh=
=2Eif
> index b5bd2762ef96..0941f133711e 100644
> --- a/policy/modules/services/ssh.if
> +++ b/policy/modules/services/ssh.if
> @@ -701,6 +701,25 @@ interface(`ssh_read_user_home_files',`
>  	userdom_search_user_home_dirs($1)
>  ')
> =20
> +########################################
> +## <summary>
> +##      Execute the ssh key generator in the caller domain.
> +## </summary>
> +## <param name=3D"domain">
> +##      <summary>
> +##      Domain allowed to transition.

"Domain allowed access." Its not a transition. I suppose you have a use for=
 this interface?

> +##      </summary>
> +## </param>
> +#
> +interface(`ssh_exec_keygen',`
> +        gen_require(`
> +                type ssh_keygen_exec_t;
> +        ')
> +
> +	corecmd_search_bin($1)
> +	can_exec($1, ssh_keygen_exec_t)
> +')
> +
>  ########################################
>  ## <summary>
>  ##	Execute the ssh key generator in the ssh keygen domain.
> --=20
> 2.21.0
>=20

--=20
Key fingerprint =3D 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=3Dget&search=3D0x3B6C5F1D2C7B6B02
Dominick Grift

--oLBj+sq0vYjzfsbl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEujmXliIBLFTc2Y4AJXSOVTf5R2kFAl0LnEoACgkQJXSOVTf5
R2lgBgv+NK4ZoVZaPTPMcMpF8Ri65Dxu7fQgvvfkWAPZiK3Reik15+8IGyUSdmZ2
oOlaZg0yMxZUu6B4anKOH4MZvaYRnaGqCXGNbGYHkko4e187uYjsgMi+5xt02ivf
k1kaelBdRSOObzzY8dFLCXyFY305iX6C7YtNem72qRUaiYSwqvb/YssXKB7spQel
2nGQT/e1b36uCjSGHHZ3c6AOMjBEl5w67Z0wrQHu7jTVaCGtwBw8rl5DhcbHIO7A
e6750G5OyhX8ofP3YbVEwAt4PmNqcv0T8mbiWvc53bHCgmcTzRpzxuFogJChN8YD
ARmKbiOjEkYBnB7LC0bh6vojABbbxGoZB14WAXar/2cAM5/v9RNolqdAPL1Xf+VI
5cXVsz15OQpFFfo/ekABfLsXoAxuTpmoEKm6lcZgaAdhZb5d3BLAlqscRtR/iRsW
4CC7cJOCv7xaSnpjbZqAvRVo8fxYD7NFx4atP5ZerdQgFilp0skzTtKt81wopWOL
1SGUYBPC
=afpu
-----END PGP SIGNATURE-----

--oLBj+sq0vYjzfsbl--