Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Jun 2019 16:50:11 +0200
From:   Dominick Grift <dac.override@gmail.com>
To:     Alexander Miroshnichenko <alex@millerson.name>
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ssh: Add interface ssh_search_dir
Message-ID: <20190620145011.GC2647@brutus.lan>
Mail-Followup-To: Alexander Miroshnichenko <alex@millerson.name>,
        selinux-refpolicy@vger.kernel.org
References: <20190620144138.15172-1-alex@millerson.name>
 <20190620144138.15172-3-alex@millerson.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ALfTUftag+2gvp1h"
Content-Disposition: inline
In-Reply-To: <20190620144138.15172-3-alex@millerson.name>
User-Agent: Every email client sucks, this one just sucks less.
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk


--ALfTUftag+2gvp1h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 20, 2019 at 05:41:38PM +0300, Alexander Miroshnichenko wrote:
> Create interface ssh_search_dir to allow ssh_server search for keys in no=
n-standard location.
>=20
> Signed-off-by: Alexander Miroshnichenko <alex@millerson.name>
> ---
>  policy/modules/services/ssh.if | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>=20
> diff --git a/policy/modules/services/ssh.if b/policy/modules/services/ssh=
=2Eif
> index 0941f133711e..51c64ded00c4 100644
> --- a/policy/modules/services/ssh.if
> +++ b/policy/modules/services/ssh.if
> @@ -680,6 +680,24 @@ interface(`ssh_agent_exec',`
>  	can_exec($1, ssh_agent_exec_t)
>  ')
> =20
> +########################################
> +## <summary>
> +##      Search for keys in non-standard location
> +## </summary>
> +## <param name=3D"domain">
> +##      <summary>
> +##      Domain allowed access.
> +##      </summary>
> +## </param>
> +#
> +interface(`ssh_search_dir',`
> +        gen_require(`
> +                type sshd_t;
> +        ')
> +
> +	allow sshd_t $1:dir search_dir_perms;

This is generally not allowed. The caller should generally be the source.
Regardless of the above. Keys should be in user home directories. I wonder =
what specific scenario prompted you to propose this interface?

> +')
> +
>  ########################################
>  ## <summary>
>  ##	Read ssh home directory content
> --=20
> 2.21.0
>=20

--=20
Key fingerprint =3D 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=3Dget&search=3D0x3B6C5F1D2C7B6B02
Dominick Grift

--ALfTUftag+2gvp1h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEujmXliIBLFTc2Y4AJXSOVTf5R2kFAl0LnR8ACgkQJXSOVTf5
R2lR4wv/ca0OCq/YHBE/YOv2Sc1iuAlw2MzLTVRrADrf2RfroeBhQJ4CbW7lytDl
9t6vGzv3zwjzuY6dAQ/8ZQFYvku6Qu6HozBNPAKFDtMfdwdYZmX+RSvc8Ckv8v/7
Kr7/L7JznMfkEIVQsXfur2K4fC8Qe08NzjB63h54olgZLOB4S1LGY4Ur48vp7e/8
t1/ey9i5KGBP41taR9S5C8WzJE8gdQfkbaf5V697zcrfw5Rcx05kiF2zovdLD5ep
qXkTlvmqVdlzpYEIxOG/6gx7W268ix3WpuFTlKO1H6EzzOM7UbUXIJ/yYPzP26iW
Oxb9lSQZ19IUg6pLfqxeDbbijHGNKt98IO/yz4rP+tQdYys6kMZlxe/shXLW8a7d
GzHbg0rjNImYgAe180NnNTJp7bFklzs3JX4D88w4F6QhURTGf5iYlIV+7IE4LguS
d7a2503r5FsbdzSscelmrbJAa0Q9vQ9Vcbwj7G0M4BFzg+s3s5EHzeQRJnacyNOH
2rPB6MZd
=6WS5
-----END PGP SIGNATURE-----

--ALfTUftag+2gvp1h--