Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alexander Miroshnichenko <alex@millerson.name>
To:     Dominick Grift <dac.override@gmail.com>
Cc:     <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ssh: Add interface =?iso-8859-1?Q?ssh=5Fsearch=5Fdir?=
Date:   Thu, 20 Jun 2019 18:05:57 +0300
MIME-Version: 1.0
Message-ID: <642ea6d9-97c9-4ec4-a7ed-84995a953b48@millerson.name>
In-Reply-To: <20190620145011.GC2647@brutus.lan>
References: <20190620144138.15172-1-alex@millerson.name>
 <20190620144138.15172-3-alex@millerson.name>
 <20190620145011.GC2647@brutus.lan>
User-Agent: Trojita/0.7; Qt/5.12.3; xcb; Linux; Gentoo Base System release 2.6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On =D1=87=D0=B5=D1=82=D0=B2=D0=B5=D1=80=D0=B3, 20 =D0=B8=D1=8E=D0=BD=D1=8F 20=
19 =D0=B3. 17:50:11 MSK, Dominick Grift wrote:
> On Thu, Jun 20, 2019 at 05:41:38PM +0300, Alexander Miroshnichenko wrote:
>> Create interface ssh_search_dir to allow ssh_server search for=20
>> keys in non-standard location.
>>=20
>> Signed-off-by: Alexander Miroshnichenko <alex@millerson.name>
>> ---
>>  policy/modules/services/ssh.if | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>=20
>> diff --git a/policy/modules/services/ssh.if=20
>> b/policy/modules/services/ssh.if
>> index 0941f133711e..51c64ded00c4 100644
>> --- a/policy/modules/services/ssh.if
>> +++ b/policy/modules/services/ssh.if
>> @@ -680,6 +680,24 @@ interface(`ssh_agent_exec',`
>>  =09can_exec($1, ssh_agent_exec_t)
>>  ')
>> =20
>> +########################################
>> +## <summary>
>> +##      Search for keys in non-standard location
>> +## </summary>
>> +## <param name=3D"domain">
>> +##      <summary>
>> +##      Domain allowed access.
>> +##      </summary>
>> +## </param>
>> +#
>> +interface(`ssh_search_dir',`
>> +        gen_require(`
>> +                type sshd_t;
>> +        ')
>> +
>> +=09allow sshd_t $1:dir search_dir_perms;
>
> This is generally not allowed. The caller should generally be the source.
> Regardless of the above. Keys should be in user home=20
> directories. I wonder what specific scenario prompted you to=20
> propose this interface?

GIT hosting software like gitolite/gitosis/gitea manage users ssh keys and=20=

store them own location like /var/lib/gitolite/.ssh .=20
/var/lib/gitolite have gitosis_var_lib_t type,=20
/var/lib/gitolite/.ssh have gitosis_ssh_home_t type (in patched policy=20
which=20
I want to submit).
If sshd does not have { search getattr } permissions to full path to ssh=20
key=20
user fail to login.
Can you propose corret way to give such permissions to multiple policies?
It is incorrect to label /var/lib/gitolite as user_home_dir_t type, IMHO.

>> +')
>> +
>>  ########################################
>>  ## <summary>
>>  ##=09Read ssh home directory content ...
>